mirror of
https://github.com/zebrajr/node.git
synced 2026-01-15 12:15:26 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
66 lines
1.6 KiB
JavaScript
66 lines
1.6 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const cluster = require('cluster');
|
|
const net = require('net');
|
|
|
|
assert.throws(() => {
|
|
new net.Socket({ fd: -1 });
|
|
}, { code: 'ERR_OUT_OF_RANGE' });
|
|
|
|
assert.throws(() => {
|
|
new net.Socket({ fd: 'foo' });
|
|
}, { code: 'ERR_INVALID_ARG_TYPE' });
|
|
|
|
function test(sock, readable, writable) {
|
|
let socket;
|
|
if (sock instanceof net.Socket) {
|
|
socket = sock;
|
|
} else {
|
|
socket = new net.Socket(sock);
|
|
socket.unref();
|
|
}
|
|
|
|
assert.strictEqual(socket.readable, readable);
|
|
assert.strictEqual(socket.writable, writable);
|
|
}
|
|
|
|
if (cluster.isMaster) {
|
|
test(undefined, false, false);
|
|
|
|
const server = net.createServer(common.mustCall((socket) => {
|
|
socket.unref();
|
|
test(socket, true, true);
|
|
test({ handle: socket._handle }, false, false);
|
|
test({ handle: socket._handle, readable: true, writable: true },
|
|
true, true);
|
|
server.close();
|
|
}));
|
|
|
|
server.listen(common.mustCall(() => {
|
|
const { port } = server.address();
|
|
const socket = net.connect(port, common.mustCall(() => {
|
|
test(socket, true, true);
|
|
socket.end();
|
|
}));
|
|
|
|
test(socket, false, true);
|
|
}));
|
|
|
|
cluster.setupMaster({
|
|
stdio: ['pipe', 'pipe', 'pipe', 'ipc', 'pipe', 'pipe', 'pipe']
|
|
});
|
|
|
|
const worker = cluster.fork();
|
|
worker.on('exit', common.mustCall((code, signal) => {
|
|
assert.strictEqual(code, 0);
|
|
assert.strictEqual(signal, null);
|
|
}));
|
|
} else {
|
|
test(4, false, false);
|
|
test({ fd: 5 }, false, false);
|
|
test({ fd: 6, readable: true, writable: true }, true, true);
|
|
process.disconnect();
|
|
}
|