mirror of
https://github.com/zebrajr/node.git
synced 2026-01-15 12:15:26 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
27 lines
809 B
JavaScript
27 lines
809 B
JavaScript
// Flags: --expose-internals
|
|
'use strict';
|
|
require('../common');
|
|
const assert = require('assert');
|
|
const {
|
|
validateInteger
|
|
} = require('internal/validators');
|
|
const { MAX_SAFE_INTEGER, MIN_SAFE_INTEGER } = Number;
|
|
const outOfRangeError = {
|
|
code: 'ERR_OUT_OF_RANGE',
|
|
name: 'RangeError'
|
|
};
|
|
|
|
// validateInteger() defaults to validating safe integers.
|
|
validateInteger(MAX_SAFE_INTEGER, 'foo');
|
|
validateInteger(MIN_SAFE_INTEGER, 'foo');
|
|
assert.throws(() => {
|
|
validateInteger(MAX_SAFE_INTEGER + 1, 'foo');
|
|
}, outOfRangeError);
|
|
assert.throws(() => {
|
|
validateInteger(MIN_SAFE_INTEGER - 1, 'foo');
|
|
}, outOfRangeError);
|
|
|
|
// validateInteger() works with unsafe integers.
|
|
validateInteger(MAX_SAFE_INTEGER + 1, 'foo', 0, MAX_SAFE_INTEGER + 1);
|
|
validateInteger(MIN_SAFE_INTEGER - 1, 'foo', MIN_SAFE_INTEGER - 1);
|