Anna Henningsen 624fa4147a http2: fix file close error condition at respondWithFd ...

Closing a FileHandle almost never fails, so it was hard to
notice before that `stream.emit(err)` would not emit an error
event due to the missing event name.

Destroying the stream with the error seems like the right thing
to do in that scenario.

PR-URL: https://github.com/nodejs/node/pull/29884
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>

2019-10-10 17:37:57 -07:00

..

internal

http2: fix file close error condition at respondWithFd

2019-10-10 17:37:57 -07:00

_http_agent.js

http: throw if 'host' agent header is not a string value

2019-09-18 06:08:52 -07:00

_http_client.js

lib: introduce no-mixed-operators eslint rule to lib

2019-10-05 13:59:32 -07:00

_http_common.js

http: remove legacy parser

2019-09-20 20:18:35 +02:00

_http_incoming.js

http: replace superfluous connection property with getter/setter

2019-08-17 06:21:59 -07:00

_http_outgoing.js

stream: disallow stream methods on finished stream

2019-08-20 08:47:19 -07:00

_http_server.js

src: bring 425 status code name into accordance with RFC 8470

2019-10-10 10:48:13 -07:00

_stream_duplex.js

http,stream: add writableEnded

2019-08-17 00:28:06 -07:00

_stream_passthrough.js

lib: enforce the use of Object from primordials

2019-04-12 05:38:45 +02:00

_stream_readable.js

lib: introduce no-mixed-operators eslint rule to lib

2019-10-05 13:59:32 -07:00

_stream_transform.js

stream: remove TODO and add a description instead

2019-05-02 23:16:14 +02:00

_stream_wrap.js

lib: assign missed deprecation code

2019-03-07 15:48:55 +01:00

_stream_writable.js

stream: always invoke callback before emitting error

2019-09-30 10:56:29 -07:00

_tls_common.js

tls: add option for private keys for OpenSSL engines

2019-09-27 15:50:56 -07:00

_tls_wrap.js

lib: introduce no-mixed-operators eslint rule to lib

2019-10-05 13:59:32 -07:00

.eslintrc.yaml

tools: prohibit Error.prepareStackTrace() usage

2019-10-05 20:19:17 -07:00

assert.js

assert: fix line number calculation after V8 upgrade

2019-10-07 03:20:07 -04:00

async_hooks.js

process: improve queueMicrotask performance

2019-06-10 07:49:40 +02:00

buffer.js

buffer: correct indexOf() error message

2019-08-28 15:13:51 -04:00

child_process.js

stream: use readableEncoding public api for child_process

2019-07-14 22:27:33 -07:00

cluster.js

…

console.js

console: split console into global.js and constructor.js

2018-12-02 04:51:18 +08:00

constants.js

lib: enforce the use of Object from primordials

2019-04-12 05:38:45 +02:00

crypto.js

lib: enforce the use of Object from primordials

2019-04-12 05:38:45 +02:00

dgram.js

dgram: use uv_udp_try_send()

2019-10-05 17:48:10 -07:00

dns.js

dns: update lookupService() first arg name

2019-08-10 19:06:21 -07:00

domain.js

domain: use strong reference to domain while active

2019-07-24 20:40:42 -07:00

events.js

events: improve performance of EventEmitter.emit

2019-09-24 09:12:59 +02:00

fs.js

http2: allow passing FileHandle to respondWithFD

2019-10-09 23:54:43 +02:00

http2.js

http2: order declarations in http2.js

2018-11-20 10:42:31 -08:00

http.js

lib: enforce the use of Object from primordials

2019-04-12 05:38:45 +02:00

https.js

http, http2: remove default server timeout

2019-05-09 08:54:04 -07:00

inspector.js

lib: remove the use of util.isFunction

2019-09-17 18:41:20 -07:00

module.js

lib: rework logic of stripping BOM+Shebang from commonjs

2019-05-26 13:04:29 -05:00

net.js

net: emit close on unconnected socket

2019-10-03 15:25:52 -07:00

os.js

lib: enforce the use of Object from primordials

2019-04-12 05:38:45 +02:00

path.js

lib: introduce no-mixed-operators eslint rule to lib

2019-10-05 13:59:32 -07:00

perf_hooks.js

perf_hooks: remove non-existent entries from inspect

2019-09-13 13:35:51 -07:00

process.js

…

punycode.js

lib: update punycode to 2.1.1

2018-07-16 15:55:15 -07:00

querystring.js

querystring: improve performance

2019-08-28 03:12:11 -04:00

readline.js

lib: introduce no-mixed-operators eslint rule to lib

2019-10-05 13:59:32 -07:00

repl.js

lib: stop using prepareStackTrace

2019-10-02 16:17:01 -07:00

stream.js

stream: simplify isUint8Array helper

2019-09-12 14:58:25 +02:00

string_decoder.js

lib: enforce the use of Object from primordials

2019-04-12 05:38:45 +02:00

sys.js

benchmark,doc,lib,test: capitalize comments

2019-03-10 00:44:40 +01:00

timers.js

timers: set _destroyed even if there are no destroy-hooks

2019-09-22 16:19:26 -07:00

tls.js

tls: remove unnecessary set of DEFAULT_MAX_VERSION

2019-06-17 14:39:41 +02:00

trace_events.js

perf_hooks,trace_events: use stricter equality

2019-06-16 16:45:15 +08:00

tty.js

tty: expose stream API from readline methods

2019-07-18 17:20:45 -04:00

url.js

lib: introduce no-mixed-operators eslint rule to lib

2019-10-05 13:59:32 -07:00

util.js

lib: introduce no-mixed-operators eslint rule to lib

2019-10-05 13:59:32 -07:00

v8.js

src: export v8.GetHeapCodeAndMetadataStatistics()

2019-07-30 11:36:51 -07:00

vm.js

vm: refactor SourceTextModule

2019-10-02 15:54:35 -07:00

worker_threads.js

worker: add ability to unshift message from MessagePort

2019-05-19 22:01:34 +02:00

zlib.js

zlib: remove usage of public util module

2019-07-19 11:06:29 -07:00