mirror of
https://github.com/zebrajr/node.git
synced 2026-01-15 12:15:26 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
78 lines
2.6 KiB
JavaScript
78 lines
2.6 KiB
JavaScript
// Copyright Joyent, Inc. and other Node contributors.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a
|
|
// copy of this software and associated documentation files (the
|
|
// "Software"), to deal in the Software without restriction, including
|
|
// without limitation the rights to use, copy, modify, merge, publish,
|
|
// distribute, sublicense, and/or sell copies of the Software, and to permit
|
|
// persons to whom the Software is furnished to do so, subject to the
|
|
// following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included
|
|
// in all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
|
|
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
|
|
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
|
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
|
|
// USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
|
|
'use strict';
|
|
const common = require('../common');
|
|
const net = require('net');
|
|
const assert = require('assert');
|
|
const { inspect } = require('util');
|
|
|
|
// Verify that invalid delays throw
|
|
const s = new net.Socket();
|
|
const nonNumericDelays = [
|
|
'100', true, false, undefined, null, '', {}, () => {}, []
|
|
];
|
|
const badRangeDelays = [-0.001, -1, -Infinity, Infinity, NaN];
|
|
const validDelays = [0, 0.001, 1, 1e6];
|
|
const invalidCallbacks = [
|
|
1, '100', true, false, null, {}, [], Symbol('test')
|
|
];
|
|
|
|
|
|
for (let i = 0; i < nonNumericDelays.length; i++) {
|
|
assert.throws(() => {
|
|
s.setTimeout(nonNumericDelays[i], () => {});
|
|
}, { code: 'ERR_INVALID_ARG_TYPE' }, nonNumericDelays[i]);
|
|
}
|
|
|
|
for (let i = 0; i < badRangeDelays.length; i++) {
|
|
assert.throws(() => {
|
|
s.setTimeout(badRangeDelays[i], () => {});
|
|
}, { code: 'ERR_OUT_OF_RANGE' }, badRangeDelays[i]);
|
|
}
|
|
|
|
for (let i = 0; i < validDelays.length; i++) {
|
|
s.setTimeout(validDelays[i], () => {});
|
|
}
|
|
|
|
for (let i = 0; i < invalidCallbacks.length; i++) {
|
|
[0, 1].forEach((mesc) =>
|
|
assert.throws(
|
|
() => s.setTimeout(mesc, invalidCallbacks[i]),
|
|
{
|
|
code: 'ERR_INVALID_CALLBACK',
|
|
name: 'TypeError',
|
|
message: 'Callback must be a function. ' +
|
|
`Received ${inspect(invalidCallbacks[i])}`
|
|
}
|
|
)
|
|
);
|
|
}
|
|
|
|
const server = net.Server();
|
|
server.listen(0, common.mustCall(() => {
|
|
const socket = net.createConnection(server.address().port);
|
|
socket.setTimeout(1, common.mustCall(() => {
|
|
socket.destroy();
|
|
server.close();
|
|
}));
|
|
}));
|