node/tools/msvs at 328bdac7f024110bc8f461cb318c533e1507360c - node

mirror of https://github.com/zebrajr/node.git synced 2026-01-15 12:15:26 +00:00

Files

Tobias Nießen 0ae8bf8dbc msi: do not create AppData\Roaming\npm

This effectively reverts e431cae7e7 due to
security concerns. The directory is being created with elevated
privileges but its path may depend on an unprivileged user's environment
variables. Creating a directory in certain sensitive locations can cause
Windows to become inoperable.

Creating AppData\Roaming\npm was an intentional addition in order to
resolve https://github.com/nodejs/node-v0.x-archive/issues/8141, which
appears to have been a common issue for users of npm. However, this was
implemented before 4cfe5eb9af, which
changed the MSI installation scope to perMachine. There were concerns
about creating the npm directory in that PR, albeit not related to
security (see https://github.com/nodejs/node-v0.x-archive/pull/25640).

Refs: https://github.com/nodejs/node-v0.x-archive/issues/8141
Refs: https://github.com/nodejs/node-v0.x-archive/pull/8838
Refs: https://github.com/nodejs/node-v0.x-archive/pull/25640
PR-URL: https://github.com/nodejs-private/node-private/pull/408
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
CVE-ID: CVE-2023-30585

2023-06-20 17:30:15 -03:00

install_tools

doc: consolidate use of multiple-byte units

2022-04-20 00:46:37 +02:00

msi

msi: do not create AppData\Roaming\npm

2023-06-20 17:30:15 -03:00

npm

…

pch

build: adapt v8_pch.h to V8 9.3

2021-08-30 21:03:23 +02:00