Files
node/lib
Tobias Nießen 29af9cea7f crypto: fix misleading positional argument
The fourth positional argument of `createCipherBase` is `true` when
called from within the `Cipheriv` constructor and `false`when called
from within the `Decipheriv` constructor. This value is then passed to
the `CipherBase::New()` method, which treats it as follows:

    args[0]->IsTrue() ? kCipher : kDecipher

However, the current name of said positional argument is `decipher` and
thus indicates the exact opposite: when the argument is set to true, the
instance is *not* a `Decipheriv` object. Therefore, this commit renames
the argument to `isEncrypt`, which matches the actual semantics.

PR-URL: https://github.com/nodejs/node/pull/57843
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2025-04-13 23:22:02 +00:00
..
2024-09-24 19:48:15 +00:00
2024-10-09 06:42:16 +00:00
2025-03-04 08:33:21 -08:00
2024-12-15 14:19:27 +00:00
2024-10-09 06:42:16 +00:00
2024-10-09 06:42:16 +00:00
2025-01-04 18:30:04 +00:00
2025-02-01 02:13:57 +00:00
2025-03-04 11:14:34 +00:00