mirror of
https://github.com/zebrajr/node.git
synced 2026-01-15 12:15:26 +00:00
e38ce27f3c
This change refactors `StringBytes::WriteUCS2()` in multiple ways. The `flags` argument being passed to `WriteUCS2()` is not useful: the only really relevant flag is `NO_NULL_TERMINATION` since V8 ignores `REPLACE_INVALID_UTF8`, `HINT_MANY_WRITES_EXPECTED`, and `PRESERVE_ONE_BYTE_NULL` for UTF-16 strings. However, `WriteUCS2()` might not null-terminate the result correctly regardless of whether `NO_NULL_TERMINATION` is set because it makes multiple calls to `String::Write()` internally. For these reasons, this patch removes the `flags` argument entirely and always assumes `NO_NULL_TERMINATION`. Next, this patch replaces the calls to the deprecated function `String::Write()` with calls to the new function `String::WriteV2()`, which always succeeds and always writes a predictable number of characters, removing the need to deal with a return value here. Lastly, this patch simplifies the implementation of `WriteUCS2()` and computes the exact number of characters `nchars` from the beginning, removing the need to later check again if the number of characters is zero. PR-URL: https://github.com/nodejs/node/pull/58163 Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: James M Snell <jasnell@gmail.com>
110 lines
4.2 KiB
C++
110 lines
4.2 KiB
C++
// Copyright Joyent, Inc. and other Node contributors.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a
|
|
// copy of this software and associated documentation files (the
|
|
// "Software"), to deal in the Software without restriction, including
|
|
// without limitation the rights to use, copy, modify, merge, publish,
|
|
// distribute, sublicense, and/or sell copies of the Software, and to permit
|
|
// persons to whom the Software is furnished to do so, subject to the
|
|
// following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included
|
|
// in all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
|
|
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
|
|
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
|
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
|
|
// USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
|
|
#ifndef SRC_STRING_BYTES_H_
|
|
#define SRC_STRING_BYTES_H_
|
|
|
|
#if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS
|
|
|
|
// Decodes a v8::Local<v8::String> or Buffer to a raw char*
|
|
|
|
#include "v8.h"
|
|
#include "env-inl.h"
|
|
|
|
#include <string>
|
|
|
|
namespace node {
|
|
|
|
class StringBytes {
|
|
public:
|
|
class InlineDecoder : public MaybeStackBuffer<char> {
|
|
public:
|
|
inline v8::Maybe<void> Decode(Environment* env,
|
|
v8::Local<v8::String> string,
|
|
enum encoding enc) {
|
|
size_t storage;
|
|
if (!StringBytes::StorageSize(env->isolate(), string, enc).To(&storage))
|
|
return v8::Nothing<void>();
|
|
AllocateSufficientStorage(storage);
|
|
const size_t length =
|
|
StringBytes::Write(env->isolate(), out(), storage, string, enc);
|
|
|
|
// No zero terminator is included when using this method.
|
|
SetLength(length);
|
|
return v8::JustVoid();
|
|
}
|
|
|
|
inline size_t size() const { return length(); }
|
|
};
|
|
|
|
// Fast, but can be 2 bytes oversized for Base64, and
|
|
// as much as triple UTF-8 strings <= 65536 chars in length
|
|
static v8::Maybe<size_t> StorageSize(v8::Isolate* isolate,
|
|
v8::Local<v8::Value> val,
|
|
enum encoding enc);
|
|
|
|
// Precise byte count, but slightly slower for Base64 and
|
|
// very much slower for UTF-8
|
|
static v8::Maybe<size_t> Size(v8::Isolate* isolate,
|
|
v8::Local<v8::Value> val,
|
|
enum encoding enc);
|
|
|
|
// Write the bytes from the string or buffer into the char*
|
|
// returns the number of bytes written, which will always be
|
|
// <= buflen. Use StorageSize/Size first to know how much
|
|
// memory to allocate.
|
|
static size_t Write(v8::Isolate* isolate,
|
|
char* buf,
|
|
size_t buflen,
|
|
v8::Local<v8::Value> val,
|
|
enum encoding enc);
|
|
|
|
// Take the bytes in the src, and turn it into a Buffer or String.
|
|
static v8::MaybeLocal<v8::Value> Encode(v8::Isolate* isolate,
|
|
const char* buf,
|
|
size_t buflen,
|
|
enum encoding encoding);
|
|
|
|
// Warning: This reverses endianness on BE platforms, even though the
|
|
// signature using uint16_t implies that it should not.
|
|
// However, the brokenness is already public API and can't therefore
|
|
// be changed easily.
|
|
static v8::MaybeLocal<v8::Value> Encode(v8::Isolate* isolate,
|
|
const uint16_t* buf,
|
|
size_t buflen);
|
|
|
|
static v8::MaybeLocal<v8::Value> Encode(v8::Isolate* isolate,
|
|
const char* buf,
|
|
enum encoding encoding);
|
|
|
|
private:
|
|
static size_t WriteUCS2(v8::Isolate* isolate,
|
|
char* buf,
|
|
size_t buflen,
|
|
v8::Local<v8::String> str);
|
|
};
|
|
|
|
} // namespace node
|
|
|
|
#endif // defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS
|
|
|
|
#endif // SRC_STRING_BYTES_H_
|