OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2026-01-15 12:15:26 +00:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity
37,553 Commits 30 Branches 683 Tags
f2ee81839ac00dcf234cb6940931e2c40b9b58ee
Commit Graph

24 Commits

Author SHA1 Message Date
Moshe Atlow
119559a361 tools: do not run CQ on non-fast-tracked PRs open for less than 2 days 
PR-URL: https://github.com/nodejs/node/pull/45407
Fixes: https://github.com/nodejs/node/issues/45405
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2022-11-12 16:22:02 +00:00
Luigi Pinca
7ed44db558 tools: do not use the set-output command in workflows 
The `set-output` command is deprecated. Use the `GITHUB_OUTPUT`
environment file.

Refs: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
PR-URL: https://github.com/nodejs/node/pull/45024
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2022-10-19 06:24:58 +00:00
Varun Sharma
d6988ec9be build: add GitHub token permissions for workflows 
Signed-off-by: Varun Sharma <varunsh@stepsecurity.io>

PR-URL: https://github.com/nodejs/node/pull/43743
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2022-07-12 22:50:46 +01:00
Antoine du Hamel
d320d459d2 tools: update GHA actions version 
PR-URL: https://github.com/nodejs/node/pull/42498
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2022-03-30 14:07:02 +01:00
Eliaz Bobadilla
2e6d5e111c build: bump actions/checkout 
https://github.com/actions/checkout\#checkout-v3

PR-URL: https://github.com/nodejs/node/pull/42460
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-03-27 21:34:40 -07:00
Michaël Zasso
34cf563add build: prevent concurrent CI and CQ workflow runs 
Use concurrency groups to prevent new runs from being started while a
previous job is already running. This can happen when a lot of unrelated
jobs are pending because of runner exhaustion.

PR-URL: https://github.com/nodejs/node/pull/42016
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-02-16 16:37:29 +00:00
Mestery
8e653d9898 build,tools: change the quotes in YAML 
Remove useless quotes and use single quotes when needed.

PR-URL: https://github.com/nodejs/node/pull/41756
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
 2022-02-14 19:09:17 +01:00
Antoine du Hamel
10df3af981 tools: fix CQ and auto-start-ci jobs 
PR-URL: https://github.com/nodejs/node/pull/41230
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2021-12-18 06:07:22 -08:00
Antoine du Hamel
587b167cc4 tools: fix GitHub Actions status when CQ is empty 
Refs: https://github.com/nodejs/node/pull/40985#issuecomment-995252065

PR-URL: https://github.com/nodejs/node/pull/41193
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-12-18 01:52:54 +00:00
Mestery
f404cd5ce2 build: use gh cli in workflows file 
PR-URL: https://github.com/nodejs/node/pull/40985
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-12-14 19:06:36 +00:00
Rich Trott
73fe15bf24 build: fix commit-queue-rebase functionality 
For commit-queue-rebase only, commit-queue.sh uses `git push` which
requires the credentials from the git checkout. Remove
`persist-credentials: false` from this workflow.

PR-URL: https://github.com/nodejs/node/pull/41140
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2021-12-11 11:00:00 +00:00
Rich Trott
1217087110 build: set persist-credentials: false on workflows 
Out of extra caution, instruct `actions/checkout` to not save GitHub
authentication credentials in the git config for use by future steps.

PR-URL: https://github.com/nodejs/node/pull/40972
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-11-27 22:12:26 +00:00
Michaël Zasso
873119385f tools: simplify and fix commit queue 
Use `gh` CLI for CI and commit queue jobs, and use the correct token
to merge PRs.

PR-URL: https://github.com/nodejs/node/pull/40742
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
 2021-11-07 15:26:45 +01:00
Michaël Zasso
f367af4434 tools: extend default yamllint config 
PR-URL: https://github.com/nodejs/node/pull/40150
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-09-21 17:03:51 +00:00
Rich Trott
d6bb7ed6c8 build: use lts shorthand in GitHub Actions 
Rather than hard-coding GitHub Actions to use Node.js 14.x, use the
`lts/*` shorthand for "most recent LTS version".

PR-URL: https://github.com/nodejs/node/pull/39538
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-07-29 04:57:11 +00:00
Mary Marchini
52f8471b52 build: fix commit-queue default branch 
`github.repository.default_branch` is not a valid context variable, and
GitHub doesn't have a context or environment variable containing the
default branch. It does have `github.ref` and `$GITHUB_REF`, which
contains the default branch _reference_ (as in `refs/heads/<branch>`),
so we can use that and remove the `refs/heads/` prefix.

PR-URL: https://github.com/nodejs/node/pull/38998
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
 2021-06-10 12:21:28 -07:00
pengjie
4c508f51c0 tools: update setup-node to setup-node@v2 
Signed-off-by: pengjie <37610029@qq.com>

PR-URL: https://github.com/nodejs/node/pull/38825
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2021-05-29 12:48:58 +00:00
Antoine du Hamel
b0341512b8 tools: make GH Actions workflows work if default branch is not master 
PR-URL: https://github.com/nodejs/node/pull/38516
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
 2021-05-04 13:21:20 -07:00
Antoine du Hamel
876d81624d build,tools: gitHub Actions: use Node.js Fermium 
PR-URL: https://github.com/nodejs/node/pull/35840
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2020-10-30 12:11:13 +01:00
Michaël Zasso
cfbbeea4a1 build: use GITHUB_ENV file to set env variables 
The other way is deprecated.

PR-URL: https://github.com/nodejs/node/pull/35638
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2020-10-16 08:09:57 +02:00
Michaël Zasso
8a93b371a3 build: do not install jq in workflows 
It is already installed in the GitHub runners.

PR-URL: https://github.com/nodejs/node/pull/35638
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2020-10-16 08:09:56 +02:00
Mary Marchini
919be9196f build: fix CQ after latest ncu release 
The new behavior of node-core-utils (which fetches the merge commit
instead of fetching the patch files) requires the whole repo to be
cloned, instead of just the last commit.

PR-URL: https://github.com/nodejs/node/pull/35468
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
 2020-10-02 13:52:40 -07:00
Denys Otrishko
6199678d67 build: use latest node-core-utils from npm 
PR-URL: https://github.com/nodejs/node/pull/34969
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
 2020-08-31 14:22:01 -07:00
Mary Marchini
a84716a21b build: implement a Commit Queue in Actions 
This is a (still experimental) implementation of a Commit Queue on
GitHub Actions, using labels and the scheduler event to land Pull
Requests. It uses `node-core-utils` to validate Pull Requests and to
prepare the commit message, and then it uses a GitHub personal token to
push changes back to the repository. If the Queue fails to land a Pull
Request, that PR will be removed from the queue and the
`node-core-utils` output will be pasted in the Pull Request.

An overview of the implementation is provided in
doc/guides/commit-queue.md, as well as current limitations.

Ref: https://github.com/mmarchini-oss/automated-merge-test
Ref: https://github.com/nodejs/build/issues/2201

PR-URL: https://github.com/nodejs/node/pull/34112
Refs: https://github.com/mmarchini-oss/automated-merge-test
Refs: https://github.com/nodejs/build/issues/2201
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
 2020-08-13 18:47:27 -07:00