Nimit
df05b0785b
doc: add useful v8 option section
...
This adds new section for v8 options and --max-old-space-size
Fixes: https://github.com/nodejs/node/issues/32252
PR-URL: https://github.com/nodejs/node/pull/32262
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
2020-04-11 16:07:55 +05:30
Rich Trott
1535243008
doc: split process.umask() entry into two
...
Split doc entries for process.umask() into one entry for process.umask()
(which is deprecated) and another for `process.umask(mask)` which is
not deprecated.
PR-URL: https://github.com/nodejs/node/pull/32711
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
2020-04-10 13:21:11 -07:00
himself65
d0a3bf1f11
perf_hooks: allow omitted parameters in 'performance.measure'
...
Make `startMark` and `endMark` parameters optional.
PR-URL: https://github.com/nodejs/node/pull/32651
Fixes: https://github.com/nodejs/node/issues/32647
Refs: https://www.w3.org/TR/user-timing-2/#measure-method
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2020-04-10 18:08:30 +08:00
Gabriel Schulhof
aeb7084fe6
n-api: detect deadlocks in thread-safe function
...
We introduce status `napi_would_deadlock` to be used as a return status
by `napi_call_threadsafe_function` if the call is made with
`napi_tsfn_blocking` on the main thread and the queue is full.
PR-URL: https://github.com/nodejs/node/pull/32689
Fixes: https://github.com/nodejs/node/issues/32615
Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: David Carlier <devnexen@gmail.com >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com >
2020-04-09 02:41:28 -07:00
Michael Dawson
2681cba62e
doc: clarify behavior of napi_get_typedarray_info
...
Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com >
Fixes: https://github.com/nodejs/node/issues/32089
PR-URL: https://github.com/nodejs/node/pull/32603
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-04-08 14:57:52 -04:00
unknown
944d8626b3
util: add maxStrLength option to inspect function
...
Refs: https://github.com/nodejs/node/issues/25478
PR-URL: https://github.com/nodejs/node/pull/32392
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Matheus Marchini <mat@mmarchini.me >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: James M Snell <jasnell@gmail.com >
2020-04-08 18:02:54 +02:00
Rich Trott
c849f2d4f8
doc: remove optional parameter from markdown anchor link
...
Fix up a few instances so that lines don't xceed 80 characters.
PR-URL: https://github.com/nodejs/node/pull/32671
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
2020-04-07 15:18:13 -07:00
Harshitha KP
8c12a08de5
doc: clarify listening event
...
Co-authored-by: Divyanshu <dsinecos@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/32581
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2020-04-07 20:31:40 +02:00
Andrey Pechkurov
561dda273f
async_hooks: move to lazy destroy hook registration in AsyncResource
...
PR-URL: https://github.com/nodejs/node/pull/32429
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de >
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com >
2020-04-06 16:14:43 +02:00
Dave Vandyke
8c0a17ae28
doc: correct version metadata for Readable.from
...
PR-URL: https://github.com/nodejs/node/pull/32639
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2020-04-05 21:16:39 +02:00
Juan José Arboleda
34a4ab7278
doc: clarify docs fs.watch exception may be emitted
...
Fixes: https://github.com/nodejs/node/issues/29894
PR-URL: https://github.com/nodejs/node/pull/32513
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
2020-04-05 20:50:23 +02:00
himself65
cee396ea58
doc: add unreachable code on events example
...
PR-URL: https://github.com/nodejs/node/pull/32364
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2020-04-05 20:45:29 +02:00
Harshitha KP
d03d9a05f0
doc: clarify length param in buffer.write
...
`buffer.write` documentation has an incaccuracy w.r.t the `length`
parameter: It says default number of bytes written is
`buf.length - offset`. Change it to:
If the buffer has sufficient space from the offset, the string is
written upto `length`.
If the buffer is short in space, only `buf.length - offset` bytes are
written.
Refs: https://github.com/nodejs/node/pull/32104#discussion_r388524733
PR-URL: https://github.com/nodejs/node/pull/32119
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2020-04-05 20:36:24 +02:00
Thomas Watson
04b71848af
doc: document that server.address() can return null
...
PR-URL: https://github.com/nodejs/node/pull/32519
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Evan Lucas <evanlucas@me.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-04-04 21:43:08 -07:00
Richard Lau
b9da063ae9
doc: return type of crypto.getFips() may change
...
Document that the return type of `crypto.getFips()` may change in a
future semver-major release from a `number` to a `boolean`.
PR-URL: https://github.com/nodejs/node/pull/32580
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Signed-off-by: Richard Lau <riclau@uk.ibm.com >
2020-04-03 07:18:08 -04:00
Richard Lau
d4fd03e673
doc: fix return type of crypto.getFips()
...
`crypto.getFips()` returns a number, not a boolean.
PR-URL: https://github.com/nodejs/node/pull/32580
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Signed-off-by: Richard Lau <riclau@uk.ibm.com >
2020-04-03 07:17:58 -04:00
Harshitha KP
79478113d4
doc: clarify requireManualDestroy option
...
Fixes: https://github.com/nodejs/node/issues/32409
PR-URL: https://github.com/nodejs/node/pull/32514
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com >
2020-04-03 01:41:18 +02:00
Jan Krems
9129ab1996
module: expose exports conditions to loaders
...
PR-URL: https://github.com/nodejs/node/pull/31303
Reviewed-By: Bradley Farias <bradley.meck@gmail.com >
Reviewed-By: Guy Bedford <guybedford@gmail.com >
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com >
2020-04-03 01:29:39 +02:00
Juan José Arboleda
ff2f47d786
worker: support MessagePort to workers data
...
PR-URL: https://github.com/nodejs/node/pull/32278
Fixes: https://github.com/nodejs/node/issues/32250
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
2020-04-03 01:12:19 +02:00
Anna Henningsen
5661121ae4
doc: add missing changes: entry for dns.ALL
...
Refs: https://github.com/nodejs/node/pull/32183
PR-URL: https://github.com/nodejs/node/pull/32617
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2020-04-03 01:06:32 +02:00
Lucas Holmquist
88b4e86fd7
fs: make parameters optional for readSync
...
This makes the offset, length and position parameters optional by
passing in an options object.
PR-URL: https://github.com/nodejs/node/pull/32460
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2020-04-02 18:34:31 +02:00
Hachimi Aa (Sfeir)
0c70e8c6e4
doc: improve fs.read documentation
...
PR-URL: https://github.com/nodejs/node/pull/29270
Reviewed-By: Robert Nagy <ronagy@icloud.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2020-04-02 18:09:46 +02:00
Guy Bedford
534c204e22
module: path-only CJS exports extension searching
...
PR-URL: https://github.com/nodejs/node/pull/32351
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com >
Reviewed-By: Bradley Farias <bradley.meck@gmail.com >
Reviewed-By: Jan Krems <jan.krems@gmail.com >
Reviewed-By: Myles Borins <myles.borins@gmail.com >
2020-03-31 20:39:01 -06:00
cjihrig
60c4c2b6c5
src: runtime deprecate process.umask()
...
This commit runtime deprecates calling process.umask() with
no arguments.
PR-URL: https://github.com/nodejs/node/pull/32499
Fixes: https://github.com/nodejs/node/issues/32321
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
2020-03-31 22:05:07 -04:00
cjihrig
75ee5b2622
doc: deprecate process.umask() with no arguments
...
This commit introduces a documentation deprecation for calling
process.umask() with no arguments.
PR-URL: https://github.com/nodejs/node/pull/32499
Fixes: https://github.com/nodejs/node/issues/32321
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
2020-03-31 22:04:53 -04:00
Gabriel Schulhof
e158218fb2
doc: update context-aware section of addon doc
...
Replace the portion of the context-aware addon example that advocates
for managing the life cycle of the per-addon-instance data using a
weak reference with code that illustrates how to manage its life cycle
using an environment cleanup hook.
Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com >
PR-URL: https://github.com/nodejs/node/pull/28659
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com >
2020-03-31 10:22:12 -07:00
murgatroid99
18c3ff99aa
dns: add dns.ALL hints flag constant
...
PR-URL: https://github.com/nodejs/node/pull/32183
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
2020-03-30 17:21:13 +02:00
Antoine du HAMEL
f571b294f5
doc: deprecate process.mainModule
...
PR-URL: https://github.com/nodejs/node/pull/32232
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Gus Caplan <me@gus.host >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2020-03-30 17:18:51 +02:00
Pranshu Srivastava
6ade42bb3c
doc: stream.end(cb) cb can be invoked with error
...
Update docs that the optional callback passed to
`writable.end` can be invoked in case of an error as well.
PR-URL: https://github.com/nodejs/node/pull/32238
Fixes: https://github.com/nodejs/node/issues/31220
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2020-03-30 17:15:50 +02:00
Sk Sajidul Kadir
97ef4d76c9
fs: add fs.readv()
...
Fixes: https://github.com/nodejs/node/issues/2298
PR-URL: https://github.com/nodejs/node/pull/32356
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
2020-03-30 10:18:58 +02:00
Nitin Kumar
575b4e368d
doc: fix typo in http2 docs
...
PR-URL: https://github.com/nodejs/node/pull/32292
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-03-30 09:35:21 +02:00
himself65
cc8066e0d1
doc: use uppercase on windows path
...
PR-URL: https://github.com/nodejs/node/pull/32294
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2020-03-29 22:43:53 +02:00
Filip Skokan
154d4e573a
doc,crypto: clarify oaepHash option's impact
...
PR-URL: https://github.com/nodejs/node/pull/32340
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2020-03-29 22:40:19 +02:00
unknown
400bc5cdc0
http: increase default header size from 8KB to 16KB
...
Fixes: https://github.com/nodejs/node/issues/27645
PR-URL: https://github.com/nodejs/node/pull/32520
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: David Carlier <devnexen@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
2020-03-29 22:38:57 +02:00
Anna Henningsen
c0668fec2a
doc: add missing changes: entry for mkdir
...
Refs: https://github.com/nodejs/node/pull/31530
PR-URL: https://github.com/nodejs/node/pull/32490
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Ben Coe <bencoe@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Richard Lau <riclau@uk.ibm.com >
2020-03-29 22:31:56 +02:00
unknown
cba9f2e7a2
doc: add link to DNS definition
...
PR-URL: https://github.com/nodejs/node/pull/32228
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2020-03-27 15:53:01 +01:00
Myles Borins
113c04c524
2020-03-26 Version 13.12.0 (Current)
...
macOS package notarization and a change in builder configuration:
The macOS binaries for this release, and future 13.x releases, are now
being compiled on macOS 10.15 (Catalina) with Xcode 11 to support
package notarization, a requirement for installing on .pkg files on
macOS 10.15 and later. Previous builds of Node.js 13.x were compiled on
macOS 10.11 (El Capitan) with Xcode 10. As binaries are still being
compiled to support a minimum of macOS 10.10 (Yosemite) we do not
anticipate this having a negative impact on Node.js 13.x users with
older versions of macOS.
Notable changes:
* build:
* macOS package notarization (Rod Vagg)
https://github.com/nodejs/node/pull/31459
* deps:
* upgrade npm to 6.14.4 (Ruy Adorno)
https://github.com/nodejs/node/pull/32495
* update to uvwasi 0.0.6 (Colin Ihrig)
https://github.com/nodejs/node/pull/32309
* upgrade to libuv 1.35.0 (Colin Ihrig)
https://github.com/nodejs/node/pull/32204
* lib:
* add --disable-proto option to cli (Gus Caplan)
https://github.com/nodejs/node/pull/32279
* node_report:
* move diagnostic reports to stable (Colin Ihrig)
https://github.com/nodejs/node/pull/32242
* worker:
* allow URL in Worker constructor (Antoine du HAMEL)
https://github.com/nodejs/node/pull/31664
* util:
* use a global symbol for `util.promisify.custom` (ExE Boss)
https://github.com/nodejs/node/pull/31672
PR-URL: https://github.com/nodejs/node/pull/32376
2020-03-26 18:49:28 -04:00
Rich Trott
498415b4ab
doc: remove extraneous sentence in events.md
...
Since the previous sentence describes `10` as a default, and the
following sentence explains how to modify that default, it is
unnecessary to explain that "Obviously, not all events should be limited
to just 10 listeners."
PR-URL: https://github.com/nodejs/node/pull/32457
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Myles Borins <myles.borins@gmail.com >
2020-03-26 10:23:33 -04:00
Rich Trott
7e4381318b
doc: remove unnecessary "obvious(ly)" modifiers in esm.md
...
Remove "obvious" and "obviously" in two places in esm.md. It may be
obvious to some, but likely not everyone or else it probably wouldn't be
worth mentioning/documenting.
PR-URL: https://github.com/nodejs/node/pull/32457
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Myles Borins <myles.borins@gmail.com >
2020-03-26 10:23:31 -04:00
Rich Trott
bdfbbf6c68
doc: trim wording in n-api.md text about exceptions
...
PR-URL: https://github.com/nodejs/node/pull/32457
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Myles Borins <myles.borins@gmail.com >
2020-03-26 10:23:29 -04:00
Victor
afb5639119
doc: update async_hooks.md
...
Typo `runAndReturn` -> `runSyncAndReturn`
PR-URL: https://github.com/nodejs/node/pull/32382
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2020-03-26 10:20:49 -04:00
Rich Trott
f0a33d99ec
doc: simplify and correct example descriptions in net.md
...
Instead of indicating that examples show lines to change in previous
examples, present the examples as standalone items. They suffice on
their own.
In the first of these, it says to change "the second line" of a previous
example, but if it were literally changed to the provided line, it would
result in a syntax error.
In the second of these, it gives the wrong line to change.
All of this is unnecessary and probably makes the examples harder to
follow. So simplify and treat each one as a separate example.
PR-URL: https://github.com/nodejs/node/pull/32451
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2020-03-25 23:15:20 -07:00
Richard Lau
066bdec643
doc: fix lint warning in doc/api/esm.md
...
Signed-off-by: Richard Lau <riclau@uk.ibm.com >
PR-URL: https://github.com/nodejs/node/pull/32462
Refs: https://github.com/nodejs/node/pull/31479
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
2020-03-24 14:35:35 -04:00
Rich Trott
c78d3f2256
doc: improve wording in vm.md
...
Simplify complex sentence. Remove use of "straightforward".
PR-URL: https://github.com/nodejs/node/pull/32427
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Gus Caplan <me@gus.host >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
2020-03-24 10:24:37 -07:00
Rich Trott
43922a55ea
doc: improve wording in esm.md
...
Simplify complex sentence. Remove use of "straightforward".
PR-URL: https://github.com/nodejs/node/pull/32427
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Gus Caplan <me@gus.host >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
2020-03-24 10:24:34 -07:00
Eric Dobbertin
f92df33832
doc: import clarifications with links to MDN
...
PR-URL: https://github.com/nodejs/node/pull/31479
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com >
Reviewed-By: Myles Borins <myles.borins@gmail.com >
2020-03-24 12:14:39 -04:00
Jan Krems
07a1fb953e
module: add hook for global preload code
...
PR-URL: https://github.com/nodejs/node/pull/32068
Reviewed-By: Bradley Farias <bradley.meck@gmail.com >
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com >
2020-03-23 08:39:37 -05:00
Anna Henningsen
e04f599258
doc: add basic embedding example documentation
...
PR-URL: https://github.com/nodejs/node/pull/30467
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
2020-03-21 10:58:25 +01:00
Anna Henningsen
95e3733532
cli: allow --huge-max-old-generation-size in NODE_OPTIONS
...
PR-URL: https://github.com/nodejs/node/pull/32251
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: David Carlier <devnexen@gmail.com >
2020-03-20 14:22:18 +01:00
Clemens Backes
a63db7fb5e
src: remove deprecated wasm type check
...
This removes uses of the "IsWebAssemblyCompiledModule" method, which is
deprecated in V8 v8.1 and will be removed in v8.2.
We could replace it by "IsWasmModuleObject", but since it's unused in
node anyway, I just remove the definition.
PR-URL: https://github.com/nodejs/node/pull/32116
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
2020-03-18 16:37:19 -07:00