James M Snell
0764bc4711
Revert "crypto: add crypto.timingSafeEqual"
...
This reverts commit 0fc5e0dcd9 .
Additional testing indicates that there may still be timing issues
with this implementation. Revert in order to give more time for
testing before this goes out into a release...
Refs: https://github.com/nodejs/node/pull/8040
Refs: https://github.com/nodejs/node/pull/8203
PR-URL: https://github.com/nodejs/node/pull/8225
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
2016-08-23 10:52:32 -07:00
not-an-aardvark
0fc5e0dcd9
crypto: add crypto.timingSafeEqual
...
PR-URL: https://github.com/nodejs/node/pull/8040
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com >
2016-08-19 19:36:05 -07:00
Rich Trott
330ea769ef
test: unmark test-http-regr-gh-2928 as flaky
...
The flakiness issue for test-http-regr-gh-2928 on SmartOS was resolved
in late February in https://github.com/nodejs/node/pull/5454 . This
change removes its flaky designation in sequential.status.
PR-URL: https://github.com/nodejs/node/pull/6540
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-05-04 20:15:45 -07:00
Rich Trott
4d6b4c30dd
test: remove flaky designation from fixed tests
...
`test-tls-ticket-cluster` and `test-vm-syntax-error-stderr` are no
longer flaky.
Refs: https://github.com/nodejs/node/issues/2510
Refs: https://github.com/nodejs/node/issues/2660
PR-URL: https://github.com/nodejs/node/pull/5459
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2016-02-29 10:42:57 -08:00
Rich Trott
5778f2b254
test: mark test-http-regr-gh-2928 flaky
...
`test-http-regr-gh-2928` is flay on SmartOS in CI.
Refs: https://github.com/nodejs/node/issues/5264
PR-URL: https://github.com/nodejs/node/pull/5280
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-02-17 08:45:27 -08:00
Michael Dawson
6a85ad9391
test: disable fs watch tests for AIX
...
fs watch currently needs special configuration on AIX and we
want to improve under https://github.com/nodejs/node/issues/5085 .
Tests are disabled so CI can be green and we can spot other
regressions until this work is complete.
test-async-wrap-check-providers does not aim to test fs watch
but part of the test uses it so that part has been skipped for
AIX
PR-URL: https://github.com/nodejs/node/pull/5187
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
2016-02-16 14:55:08 -05:00
Rich Trott
2848f84332
test: fix flaky test-http-regr-gh-2928
...
Fix flaky test-http-regr-gh-2928 that has been failing on Raspberry Pi
devices in CI.
Fixes: https://github.com/nodejs/node/issues/4830
PR-URL: https://github.com/nodejs/node/pull/5154
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Rod Vagg <r@va.gg >
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
2016-02-10 12:23:28 -08:00
Rich Trott
987e9e3d64
test: fix flaky test-dgram-pingpong
...
There is no guarantee UDP messages will be received. Accommodate the
occasional dropped message.
This is a functionality test, not a performance benchmark. Speed up the
test by not sending 1500 messages across three ports.
Fixes: https://github.com/nodejs/node/issues/4526
PR-URL: https://github.com/nodejs/node/pull/5125
Reviewed-By: Brian White <mscdex@mscdex.net >
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-02-07 13:01:05 -08:00
Rich Trott
6e3bccbc03
test: mark flaky tests on Raspberry Pi
...
A few tests have started failing on Raspberry Pi devices in CI.
https://ci.nodejs.org/job/node-test-binary-arm/943/
PR-URL: https://github.com/nodejs/node/pull/5082
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Roman Klauke <romaaan.git@gmail.com >
Ref: https://github.com/nodejs/node/issues/4830
Ref: https://github.com/nodejs/node/issues/3635
Ref: https://github.com/nodejs/node/issues/4526
2016-02-06 08:42:34 -08:00
Rich Trott
d9734b7cc9
test: refactor test-http-pipeline-flood
...
This extends fixes for test-https-pipeline-flood to hopefully fully
eliminate its flakiness on Windows in our continuous integration
process.
PR-URL: https://github.com/nodejs/node/pull/3636
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
2015-11-13 05:16:21 -08:00
Rich Trott
6d6bc5d9d8
test: mark http-pipeline-flood flaky
...
test-http-pipeline-flood has been flaky on Windows for some time.
Hopefully, https://github.com/nodejs/node/pull/2862 fixes it and
lands soon, but until then, let's mark it as flaky.
PR-URL: https://github.com/nodejs/node/pull/3616
Reviewed-By: Johan Bergström <bugs@bergstroem.nu >
2015-11-02 13:58:05 -08:00
Jeremiah Senkpiel
5923dee07e
test: repl-persistent-history is no longer flaky
...
The race conditions were fixed in
286ef1daca
PR-URL: https://github.com/nodejs/node/pull/3437
Reviewed By: Evan Lucas <evanlucas@me.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Johan Bergström <bugs@bergstroem.nu >
2015-10-20 10:44:06 -04:00
Rich Trott
10a32aee84
test: refactor to eliminate flaky test
...
This retains the key elements of test-child-process-fork-getconnections
(forks a child process, sends a bunch of sockets, uses getConnections()
to enumerate them) but contains some code to work around an apparent
intermittent bug that occurs on OS X where a socket seems to close
itself unexpectedly.
https://github.com/nodejs/node/issues/2610 was opened for the bug that
was causing the problem in the first place.
PR-URL: https://github.com/nodejs/node/pull/2609
Fixes: https://github.com/nodejs/node/issues/1100
Reviewed-By: jbergstroem - Johan Bergström <bugs@bergstroem.nu >
Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com >
2015-09-06 21:37:59 +10:00
João Reis
68a658d82b
test: mark test-vm-syntax-error-stderr as flaky
...
Ref: https://github.com/nodejs/node/issues/2660
PR-URL: https://github.com/nodejs/node/pull/2662
Reviewed-By: orangemocha - Alexis Campailla <orangemocha@nodejs.org >
2015-09-02 17:40:01 -04:00
João Reis
242c88b8ae
test: mark test-repl-persistent-history as flaky
...
This test is already being investigated, but until a solution is found
it should be marked flaky.
Ref: https://github.com/nodejs/node/issues/2319
Ref: https://github.com/nodejs/node/pull/2356
PR-URL: https://github.com/nodejs/node/pull/2659
Reviewed-By: orangemocha - Alexis Campailla <orangemocha@nodejs.org >
2015-09-02 13:28:27 -04:00
Alexis Campailla
34e25b2313
test: initial list of flaky tests
...
This poplulates the lists of flaky tests with tests that failed recently
in Jenkins.
PR-URL: https://github.com/nodejs/node/pull/2424
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: João Reis <reis@janeasystems.com >
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com >
2015-08-27 05:49:55 +02:00
Alexis Campailla
ff05953b8d
test: add test configuration templates
...
Template configuration files for marking tests as flaky.
PR-URL: https://github.com/nodejs/node/pull/2424
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: João Reis <reis@janeasystems.com >
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com >
2015-08-27 05:49:28 +02:00