OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2026-01-15 12:15:26 +00:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity
35,601 Commits 30 Branches 683 Tags
bde184e8abf196ecbb483eb372f0c59cd5ae327a
Commit Graph

225 Commits

Author SHA1 Message Date
Filip Skokan
d1a9c439ff build: revert fast-track changes 
PR-URL: https://github.com/nodejs/node/pull/41892
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-02-08 17:05:00 +01:00
Mestery
f7ff2ff304 build: improve consistency between workflows 
PR-URL: https://github.com/nodejs/node/pull/41791
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-02-07 17:54:31 +00:00
Michael Dawson
6c0eb942b3 doc: feature management proposal 
Refs: https://github.com/nodejs/node/discussions/40823
Refs: https://github.com/nodejs/node/issues/41113

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: https://github.com/nodejs/node/pull/41420
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
 2022-02-04 15:54:21 -05:00
Michael Dawson
a199387f04 doc: make contributing info more discoverable 
There are been several discussions in recent PRs about
the docs related to contributing not being very discoverable.
Move these docs from doc/guides/ to doc/contributing.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: https://github.com/nodejs/node/pull/41408
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2022-01-18 14:24:30 -05:00
Rich Trott
4b1ee04153 build: fix workflow access to git history 
Refs: https://github.com/nodejs/node/pull/41466

PR-URL: https://github.com/nodejs/node/pull/41472
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
 2022-01-13 15:08:44 +00:00
Rich Trott
78b3af99b3 meta: add required fields in issue templates 
Make sure there is at least one required field in each issue template.
Leave the title blank to enforce that as a required field as well.

PR-URL: https://github.com/nodejs/node/pull/41378
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2022-01-05 10:05:34 +00:00
Rich Trott
0de6a6341a meta: replace API docs issue template with form 
All other issue templates have been moved to forms, which seems to do a
good job of reducing spam issues.

PR-URL: https://github.com/nodejs/node/pull/41348
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
 2021-12-31 01:27:36 +00:00
Rich Trott
5ed706673a meta: replace feature request template with form 
The bug report form doesn't seem to result in many invalid/spam reports,
but the template still results in lots of issues opened by apparent bots
that don't modify the default template imput. Change the feature request
template to a form to hopefully better serve people proposing features
and reduce bot-generated junk issues.

PR-URL: https://github.com/nodejs/node/pull/41317
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
 2021-12-28 20:42:19 +00:00
Richard Lau
406e6d87c4 meta: update node-api team name 
The `@nodejs/n-api` team was renamed to `@nodejs/node-api`.

PR-URL: https://github.com/nodejs/node/pull/41268
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-12-23 19:49:00 +00:00
Mestery
665b404e65 build: improve readability of texts in workflows 
PR-URL: https://github.com/nodejs/node/pull/40988
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-12-19 16:12:57 +00:00
Antoine du Hamel
10df3af981 tools: fix CQ and auto-start-ci jobs 
PR-URL: https://github.com/nodejs/node/pull/41230
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2021-12-18 06:07:22 -08:00
Antoine du Hamel
587b167cc4 tools: fix GitHub Actions status when CQ is empty 
Refs: https://github.com/nodejs/node/pull/40985#issuecomment-995252065

PR-URL: https://github.com/nodejs/node/pull/41193
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-12-18 01:52:54 +00:00
Rich Trott
9d6168b407 meta: remove community-committee from CODEOWNERS 
Files previously managed by TSC + CommComm are now managed by TSC.

PR-URL: https://github.com/nodejs/node/pull/41169
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2021-12-16 14:00:08 +00:00
Rich Trott
41e1de6f40 build,tools: automate enforcement of emeritus criteria 
PR-URL: https://github.com/nodejs/node/pull/41155
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Stewart X Addison <sxa@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Gus Caplan <me@gus.host>
 2021-12-15 21:38:35 +00:00
Mestery
6267e55685 build: fix comment-labeled workflow 
Refs: https://github.com/nodejs/node/pull/40985#issuecomment-994056146

PR-URL: https://github.com/nodejs/node/pull/41176
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2021-12-14 23:09:12 +00:00
Mestery
f404cd5ce2 build: use gh cli in workflows file 
PR-URL: https://github.com/nodejs/node/pull/40985
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-12-14 19:06:36 +00:00
Rich Trott
73fe15bf24 build: fix commit-queue-rebase functionality 
For commit-queue-rebase only, commit-queue.sh uses `git push` which
requires the credentials from the git checkout. Remove
`persist-credentials: false` from this workflow.

PR-URL: https://github.com/nodejs/node/pull/41140
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2021-12-11 11:00:00 +00:00
Rich Trott
3697587c31 doc: remove OpenJSF Slack nodejs from support doc 
The OpenJSF Slack nodejs channel has a description that reads:

> 🚨 For Node.js application development questions, see:
>
> - Node Slackers: https://www.nodeslackers.com/
> - Node.js help repo: https://github.com/nodejs/help

Let's not send people with support questions there just to get
ignored or redirected elsewhere.

PR-URL: https://github.com/nodejs/node/pull/41108
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
 2021-12-09 08:14:10 -08:00
Rich Trott
781408f377 build: fail early in test-macos.yml 
PR-URL: https://github.com/nodejs/node/pull/41035
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2021-12-03 21:29:24 -08:00
Rich Trott
71c04b12a6 build: add tools/doc to tools.yml updates 
PR-URL: https://github.com/nodejs/node/pull/41036
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yash Ladha <yash@yashladha.in>
 2021-12-02 13:14:22 -08:00
Antoine du Hamel
d81f328aa5 tools: ignore unrelated workflow changes in slow Actions tests 
Changes in the workflow files never affect the node binary, running
build tasks seems unnecessary.

Refs: https://github.com/nodejs/node/pull/40928

PR-URL: https://github.com/nodejs/node/pull/40990
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-11-30 19:11:16 +00:00
Mestery
6b202cc383 build: update Actions versions 
PR-URL: https://github.com/nodejs/node/pull/40987
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-11-30 19:11:07 +00:00
Rich Trott
6fd0a60d60 tools: update ESLint update script to consolidate dependencies 
PR-URL: https://github.com/nodejs/node/pull/40995
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-11-29 14:52:36 -08:00
Rich Trott
1217087110 build: set persist-credentials: false on workflows 
Out of extra caution, instruct `actions/checkout` to not save GitHub
authentication credentials in the git config for use by future steps.

PR-URL: https://github.com/nodejs/node/pull/40972
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-11-27 22:12:26 +00:00
Rich Trott
e64c66c1a9 build: ignore unrelated workflow changes in slow Actions tests 
test-asan and test-macos are very slow and tend to get backed up. While
I'm literally waiting hours right now for test-macos to finish so I can
land a PR, I'm opening this pull request to have it be skipped when
things other than its own workflow file are the only changes in the PR.

PR-URL: https://github.com/nodejs/node/pull/40928
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2021-11-27 01:18:37 +00:00
Mestery
7d8199467d meta: add feature request label for issue template 
PR-URL: https://github.com/nodejs/node/pull/40970
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2021-11-26 07:12:51 +00:00
Antoine du Hamel
27b10881d3 tools: fix commit-lint GH Actions CI 
PR-URL: https://github.com/nodejs/node/pull/40845
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-11-25 12:14:40 -08:00
Rich Trott
f7ac6ba60c tools: ping TSC members identified as inactive 
When detecting TSC members as inactive, @-mention them in the pull
request that moves them to emeritus. This notifies them in case the pull
request is in error.

PR-URL: https://github.com/nodejs/node/pull/40915
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
 2021-11-24 18:33:04 +00:00
Rich Trott
516e29d8cf build: fix branch name for lint-md-dependencies update 
Refs: https://github.com/nodejs/node/runs/4288412090?check_suite_focus=true

PR-URL: https://github.com/nodejs/node/pull/40924
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2021-11-22 23:26:45 +00:00
Rich Trott
bad6526a00 build: fix make invocation in tools.yml 
Be in the correct directory for `make lint-md-rollup`.

PR-URL: https://github.com/nodejs/node/pull/40890
Refs: https://github.com/nodejs/node/runs/4270533399?check_suite_focus=true
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-11-22 05:01:56 +00:00
Rich Trott
129c12e252 tools: add find-inactive-tsc 
Automate the implementation of rules in the TSC Charter around automatic
removal of members who do not participate in TSC votes and attend fewer
than 25% of the meetings in a 3-month period.

PR-URL: https://github.com/nodejs/node/pull/40884
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-11-21 15:10:04 +00:00
Rich Trott
e0233fc7dc build: fix tools.yml errors 
PR-URL: https://github.com/nodejs/node/pull/40870
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-11-19 09:18:06 +00:00
Antoine du Hamel
9cd30894f6 tools: only validate first commit message of a PR 
PR-URL: https://github.com/nodejs/node/pull/40740
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-11-12 23:35:22 +01:00
Rich Trott
e8d16eee26 build: add GitHub Action to update tools modules 
Update ESLint, Babel, remark, and so on. Run once a week.

PR-URL: https://github.com/nodejs/node/pull/40644
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-11-08 11:47:51 -08:00
Michaël Zasso
8e42eaec53 meta: use form schema for flaky test template 
PR-URL: https://github.com/nodejs/node/pull/40737
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2021-11-08 13:01:53 +01:00
Michaël Zasso
873119385f tools: simplify and fix commit queue 
Use `gh` CLI for CI and commit queue jobs, and use the correct token
to merge PRs.

PR-URL: https://github.com/nodejs/node/pull/40742
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
 2021-11-07 15:26:45 +01:00
Antoine du Hamel
14825d63c0 tools: fix commit-lint workflow 
PR-URL: https://github.com/nodejs/node/pull/40673
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2021-11-01 19:57:30 +01:00
Antoine du Hamel
b5aa08d2f9 tools: avoid fetch extra commits when validating commit messages 
PR-URL: https://github.com/nodejs/node/pull/39128
Reviewed-By: Mary Marchini <oss@mmarchini.me>
 2021-10-30 17:45:25 +02:00
Rich Trott
8eebc33c02 build: skip long-running Actions for README-only modifications 
If the only file modified is README.md do not run test-linux or
build-windows tasks. This will help streamline onboarding sessions but
may help some other cases too.

PR-URL: https://github.com/nodejs/node/pull/40571
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-10-24 19:01:18 +00:00
Mestery
ed76b49834 build: fix actions pull request's branch 
PR-URL: https://github.com/nodejs/node/pull/40494
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2021-10-18 15:32:55 +02:00
Jiawen Geng
6baea14506 build: avoid run find inactive authors on forked repo 
PR-URL: https://github.com/nodejs/node/pull/40465
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2021-10-15 18:30:17 +00:00
Mestery
b80b85e130 meta: add typings to label-pr-config 
PR-URL: https://github.com/nodejs/node/pull/40401
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
 2021-10-14 11:55:09 +00:00
FrankQiu
983b757f3f build: update codeowners-validator to 0.6 
PR-URL: https://github.com/nodejs/node/pull/40307
Reviewed-By: Mary Marchini <oss@mmarchini.me>
 2021-10-13 11:31:04 +00:00
Rich Trott
73c3885e10 build: remove duplicate check for authors.yml 
update-authors.js will print if there are duplicates in the new entries
so we can remove the (not working) duplication check in the authors.yml
file. It would still be nice to get the information about duplicates
into the body of the GitHub PR so no one has to manually check for
duplicates (by either examining the file or looking at the Actions
output), but that can be a future improvement.

PR-URL: https://github.com/nodejs/node/pull/40393
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
 2021-10-12 01:48:33 +00:00
Mestery
eaa59571e0 meta: update label-pr-config 
PR-URL: https://github.com/nodejs/node/pull/40199
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-10-09 17:11:31 +00:00
FrankQiu
7752088ef6 build: support Python 3.10.0 
PR-URL: https://github.com/nodejs/node/pull/40296
Fixes: https://github.com/nodejs/node/issues/40294
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2021-10-06 17:07:07 -07:00
Rich Trott
2a3a9b8b71 build: check for duplicates in new AUTHORS entries 
When the GitHub Action adds new entries to the AUTHORS file, have it
also flag new entries that might be duplicates.

PR-URL: https://github.com/nodejs/node/pull/40264
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2021-10-03 20:44:01 +00:00
Jiawen Geng
35d9222f30 build: limit update authors CI scope 
PR-URL: https://github.com/nodejs/node/pull/40219
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2021-09-27 00:28:16 +00:00
Rich Trott
8d83c47029 tools: re-implement lint-md without unified-args 
`unified-args` ignores settings in the preset, expecting them to be in
remarkrc files or passed on the command line instead. Realizing that
we always send the same configuration options via the command-line
anyway, this removes `unified-args`. This means the preset settings are
now respected and it removes nearly 30000 lines of code in the resulting
rollup file.

I wasn't sure I was going to want to keep rollup so I started
re-implementing this without it, but ended up putting a minimal rollup
back as it still saves about 90000 lines of code vs. checking in
`node_modules`.

PR-URL: https://github.com/nodejs/node/pull/40180
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-09-25 03:51:52 +00:00
SURYAPRATAP SINGH SURYAVANSHI
c7da13c7c4 build: fix "test-internet.yml" workflows 
PR-URL: https://github.com/nodejs/node/pull/40177
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2021-09-22 15:30:57 -07:00