OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2026-01-15 12:15:26 +00:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity
36,313 Commits 30 Branches 683 Tags
a56552b65355aed01ebbbaf54ff2b91b4f877f5e
Commit Graph

255 Commits

Author SHA1 Message Date
Feng Yu
b4398df2e5 tools: refactor build-addons.js to ESM 
PR-URL: https://github.com/nodejs/node/pull/43099
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-05-22 14:28:41 +01:00
Feng Yu
5cb257958e tools: refactor update-authors.js to ESM 
PR-URL: https://github.com/nodejs/node/pull/43098
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-05-21 16:31:31 +01:00
Joyee Cheung
fbe1478077 bootstrap: include code cache in the embedded snapshot 
Since V8 code cache encodes indices to the read-only space
it is safer to make sure that the code cache is generated in the
same heap used to generate the embdded snapshot. This patch
merges the code cache builder into the snapshot builder and
makes the code cache part of node::SnapshotData that is
deserialized into the native module loader during bootstrap.

PR-URL: https://github.com/nodejs/node/pull/43023
Fixes: https://github.com/nodejs/node/issues/31074
Refs: https://github.com/nodejs/node/issues/35711
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2022-05-17 20:38:11 +08:00
Richard Lau
347000ccf8 build: set ASAN workaround 
PR-URL: https://github.com/nodejs/node/pull/43085
Refs: https://github.com/google/sanitizers/issues/1322
Refs: https://github.com/nodejs/node/issues/43082
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2022-05-14 22:05:55 -07:00
Jiawen Geng
8c800d7102 build: disable windows-2022 temporarily 
PR-URL: https://github.com/nodejs/node/pull/43093
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2022-05-14 08:47:47 -07:00
Feng Yu
be1ca70515 tools: refactor lint-sh.js to esm module 
PR-URL: https://github.com/nodejs/node/pull/42942
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2022-05-08 16:08:10 +01:00
Darshan Sen
61fefe1959 build: fix format-cpp 
According to the logs in
https://github.com/nodejs/node/pull/42681#issuecomment-1100856089,
`make format-cpp` exits with an NZEC. This change intentionally ignores
the error code because it is irrelevant. We already check if the
formatter produced a diff in the next line.

Refs: https://github.com/nodejs/node/pull/42681#issuecomment-1100856089
Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/42764
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2022-04-20 16:00:22 +01:00
Darshan Sen
fc326d674d build: improve the format-cpp error message 
This change specifies the target branch name instead of leaving that to
the committer to fill in.

Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/42765
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2022-04-20 00:26:50 +01:00
Darshan Sen
96673bcb96 build: run clang-format on CI 
We already include the tool inside tools/clang-format, so we should
start using it on CI. This attempts to run the linter only on the
commits present in an opened PR.

Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/42681
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2022-04-13 18:22:00 +01:00
Rich Trott
df20947e69 build: consolidate JS and md linting GitHub Actions 
Linting markdown runs the JavaScript linting job, so consolidate them to
conserve time and resources. Run JavaScript separately, but then run
markdown linting so it can use the cached results of the JavaScript
linting.

PR-URL: https://github.com/nodejs/node/pull/42572
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2022-04-04 00:47:02 +01:00
Michael Dawson
d80f07ba80 build: set stale action back to running nightly 
I manually ran over  the last number of weeks so that
we did not mark all of the stale isssues all at once.
We are not caught up so we can go to running daily.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: https://github.com/nodejs/node/pull/42549
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2022-04-03 16:27:12 +01:00
Antoine du Hamel
d320d459d2 tools: update GHA actions version 
PR-URL: https://github.com/nodejs/node/pull/42498
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2022-03-30 14:07:02 +01:00
Eliaz Bobadilla
2e6d5e111c build: bump actions/checkout 
https://github.com/actions/checkout\#checkout-v3

PR-URL: https://github.com/nodejs/node/pull/42460
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-03-27 21:34:40 -07:00
Michaël Zasso
e8ac3b4d68 build: rename tools workflow and add undici to it 
The workflow already updates Corepack, which is a `deps`, not a `tool`.
Add subsystem and label variables to the matrix to better control the
automated pull requests and add undici to the updated deps.

PR-URL: https://github.com/nodejs/node/pull/42246
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
 2022-03-09 20:37:39 +01:00
Mestery
24487befb7 meta: add dependencies label to label-pr-config 
PR-URL: https://github.com/nodejs/node/pull/42129
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2022-03-07 22:34:36 +00:00
Richard Lau
2d6aea7ff5 build: drop shortened URL from lint-commit-message 
The shortened link to the commit message guidelines no longer works
after they were moved from `docs/guides` to `docs/contributing`. Now
that `core-validate-commit` outputs an error message pointing to the
full URL of the commit message guidelines on failure we no longer need
to include the URL (shortened or otherwise) in the workflow title.

PR-URL: https://github.com/nodejs/node/pull/42168
Refs: https://github.com/nodejs/core-validate-commit/pull/95
Refs: https://github.com/nodejs/node/issues/41697
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2022-03-03 16:15:47 +00:00
Michael Dawson
b3723fac05 build: fix usage of input in feature action 
Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: https://github.com/nodejs/node/pull/42150
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2022-02-28 17:28:36 +00:00
Michael Dawson
a62972ab28 build: increase max ops for stale feature action 
Set the limit to match the number used in the
close stalled action. Required as not all eligeable
stale features are being processed.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: https://github.com/nodejs/node/pull/42130
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2022-02-28 11:16:15 -05:00
Maël Nison
e84b635db4 build: add corepack to the auto-updated dependencies 
PR-URL: https://github.com/nodejs/node/pull/42090
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
 2022-02-25 22:36:05 +00:00
Michael Dawson
5a65853063 build: last test of the stale feature action 
- set the days so that we process ~ 40 issues
  so that we can see what kind of feedback we get
  on saying we are going to close stale feature requests
- set the label to stale instead of stalled so that
  there is no race with the action that closes stalled
  issues
- fix the links to the feature management doc

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: https://github.com/nodejs/node/pull/42085
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2022-02-25 10:53:28 -05:00
Simen Bekkhus
a07757dc01 meta: correct link to feature request document 
PR-URL: https://github.com/nodejs/node/pull/42092
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
 2022-02-23 14:13:59 +00:00
Michael Dawson
19bf6c59ab build: update feature close action for testing 
This should process the 4 oldest feature requests.
Once we've confirmed these are ok we can adjust the
days before an issue is marked as stale.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: https://github.com/nodejs/node/pull/42082
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-02-22 17:37:32 -05:00
Michaël Zasso
5348552b93 build: cancel running CI jobs when a PR is updated 
Refs: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-using-a-fallback-value

PR-URL: https://github.com/nodejs/node/pull/42017
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2022-02-18 15:46:12 +00:00
Michael Dawson
6db686710e build: increase operations and test tag 
- increase the operations as 1 was too small to do
  anything
- add an additional tag that must be present before
  the action will run. I will manually add that tag
  to some feature requests to be able to test

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: https://github.com/nodejs/node/pull/42038
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2022-02-17 16:39:55 -05:00
Michael Dawson
b9a460e6eb build: allow manual run of feature request action 
add "workflow_dispatch:" so that action can be run
manuallyl for debugging.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: https://github.com/nodejs/node/pull/42037
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2022-02-17 20:19:39 +00:00
Michael Dawson
3fbc10d7f7 build: add action to close stale feature requests 
Implement the prodecure outlined in
https://github.com/nodejs/node/blob/master/doc/contributing/feature-request-management.md

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: https://github.com/nodejs/node/pull/41981
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
 2022-02-17 14:29:54 -05:00
Mestery
4829f85233 meta: use plain emojis instead of escape sequences 
Refs: https://github.com/nodejs/node/issues/41987

PR-URL: https://github.com/nodejs/node/pull/41989
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2022-02-17 15:13:01 +00:00
Michaël Zasso
34cf563add build: prevent concurrent CI and CQ workflow runs 
Use concurrency groups to prevent new runs from being started while a
previous job is already running. This can happen when a lot of unrelated
jobs are pending because of runner exhaustion.

PR-URL: https://github.com/nodejs/node/pull/42016
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-02-16 16:37:29 +00:00
Rich Trott
d17be0fbe5 build: move tool updates workflow runtime a day later 
Refs: https://github.com/nodejs/node/pull/41973#issuecomment-1039780665

PR-URL: https://github.com/nodejs/node/pull/41982
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
 2022-02-15 10:50:33 +00:00
Mestery
8e653d9898 build,tools: change the quotes in YAML 
Remove useless quotes and use single quotes when needed.

PR-URL: https://github.com/nodejs/node/pull/41756
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
 2022-02-14 19:09:17 +01:00
Filip Skokan
d1a9c439ff build: revert fast-track changes 
PR-URL: https://github.com/nodejs/node/pull/41892
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-02-08 17:05:00 +01:00
Mestery
f7ff2ff304 build: improve consistency between workflows 
PR-URL: https://github.com/nodejs/node/pull/41791
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-02-07 17:54:31 +00:00
Michael Dawson
6c0eb942b3 doc: feature management proposal 
Refs: https://github.com/nodejs/node/discussions/40823
Refs: https://github.com/nodejs/node/issues/41113

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: https://github.com/nodejs/node/pull/41420
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
 2022-02-04 15:54:21 -05:00
Michael Dawson
a199387f04 doc: make contributing info more discoverable 
There are been several discussions in recent PRs about
the docs related to contributing not being very discoverable.
Move these docs from doc/guides/ to doc/contributing.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: https://github.com/nodejs/node/pull/41408
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2022-01-18 14:24:30 -05:00
Rich Trott
4b1ee04153 build: fix workflow access to git history 
Refs: https://github.com/nodejs/node/pull/41466

PR-URL: https://github.com/nodejs/node/pull/41472
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
 2022-01-13 15:08:44 +00:00
Rich Trott
78b3af99b3 meta: add required fields in issue templates 
Make sure there is at least one required field in each issue template.
Leave the title blank to enforce that as a required field as well.

PR-URL: https://github.com/nodejs/node/pull/41378
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2022-01-05 10:05:34 +00:00
Rich Trott
0de6a6341a meta: replace API docs issue template with form 
All other issue templates have been moved to forms, which seems to do a
good job of reducing spam issues.

PR-URL: https://github.com/nodejs/node/pull/41348
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
 2021-12-31 01:27:36 +00:00
Rich Trott
5ed706673a meta: replace feature request template with form 
The bug report form doesn't seem to result in many invalid/spam reports,
but the template still results in lots of issues opened by apparent bots
that don't modify the default template imput. Change the feature request
template to a form to hopefully better serve people proposing features
and reduce bot-generated junk issues.

PR-URL: https://github.com/nodejs/node/pull/41317
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
 2021-12-28 20:42:19 +00:00
Richard Lau
406e6d87c4 meta: update node-api team name 
The `@nodejs/n-api` team was renamed to `@nodejs/node-api`.

PR-URL: https://github.com/nodejs/node/pull/41268
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-12-23 19:49:00 +00:00
Mestery
665b404e65 build: improve readability of texts in workflows 
PR-URL: https://github.com/nodejs/node/pull/40988
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-12-19 16:12:57 +00:00
Antoine du Hamel
10df3af981 tools: fix CQ and auto-start-ci jobs 
PR-URL: https://github.com/nodejs/node/pull/41230
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2021-12-18 06:07:22 -08:00
Antoine du Hamel
587b167cc4 tools: fix GitHub Actions status when CQ is empty 
Refs: https://github.com/nodejs/node/pull/40985#issuecomment-995252065

PR-URL: https://github.com/nodejs/node/pull/41193
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-12-18 01:52:54 +00:00
Rich Trott
9d6168b407 meta: remove community-committee from CODEOWNERS 
Files previously managed by TSC + CommComm are now managed by TSC.

PR-URL: https://github.com/nodejs/node/pull/41169
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2021-12-16 14:00:08 +00:00
Rich Trott
41e1de6f40 build,tools: automate enforcement of emeritus criteria 
PR-URL: https://github.com/nodejs/node/pull/41155
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Stewart X Addison <sxa@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Gus Caplan <me@gus.host>
 2021-12-15 21:38:35 +00:00
Mestery
6267e55685 build: fix comment-labeled workflow 
Refs: https://github.com/nodejs/node/pull/40985#issuecomment-994056146

PR-URL: https://github.com/nodejs/node/pull/41176
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2021-12-14 23:09:12 +00:00
Mestery
f404cd5ce2 build: use gh cli in workflows file 
PR-URL: https://github.com/nodejs/node/pull/40985
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-12-14 19:06:36 +00:00
Rich Trott
73fe15bf24 build: fix commit-queue-rebase functionality 
For commit-queue-rebase only, commit-queue.sh uses `git push` which
requires the credentials from the git checkout. Remove
`persist-credentials: false` from this workflow.

PR-URL: https://github.com/nodejs/node/pull/41140
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2021-12-11 11:00:00 +00:00
Rich Trott
3697587c31 doc: remove OpenJSF Slack nodejs from support doc 
The OpenJSF Slack nodejs channel has a description that reads:

> 🚨 For Node.js application development questions, see:
>
> - Node Slackers: https://www.nodeslackers.com/
> - Node.js help repo: https://github.com/nodejs/help

Let's not send people with support questions there just to get
ignored or redirected elsewhere.

PR-URL: https://github.com/nodejs/node/pull/41108
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
 2021-12-09 08:14:10 -08:00
Rich Trott
781408f377 build: fail early in test-macos.yml 
PR-URL: https://github.com/nodejs/node/pull/41035
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2021-12-03 21:29:24 -08:00
Rich Trott
71c04b12a6 build: add tools/doc to tools.yml updates 
PR-URL: https://github.com/nodejs/node/pull/41036
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yash Ladha <yash@yashladha.in>
 2021-12-02 13:14:22 -08:00