OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2026-01-15 12:15:26 +00:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity
36,879 Commits 30 Branches 683 Tags
76cdef15cd9755fe628f7e707ba6fa187352b3d1
Commit Graph

745 Commits

Author SHA1 Message Date
Tobias Nießen
e9f69e88b0 build: clarify missing clang-format tool 
PR-URL: https://github.com/nodejs/node/pull/42762
Co-authored-by: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2022-07-07 22:17:49 +02:00
Feng Yu
a42099564c tools: refactor tools/license2rtf to ESM 
This reverts commit 331088f4a4.

PR-URL: https://github.com/nodejs/node/pull/43232
Refs: https://github.com/nodejs/node/issues/43213
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2022-07-08 02:38:04 +08:00
Feng Yu
24623dc586 doc: update default branch name in Makefile 
PR-URL: https://github.com/nodejs/node/pull/43441
Refs: https://github.com/nodejs/node/issues/33864
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-06-17 09:41:07 +02:00
Richard Lau
331088f4a4 Revert "tools: refactor tools/license2rtf to ESM" 
This reverts commit 30cb1bf8b8.

PR-URL: https://github.com/nodejs/node/pull/43214
Fixes: https://github.com/nodejs/node/issues/43213
Refs: https://github.com/nodejs/node/pull/43101
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2022-05-26 17:03:12 +01:00
Feng Yu
30cb1bf8b8 tools: refactor tools/license2rtf to ESM 
PR-URL: https://github.com/nodejs/node/pull/43101
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2022-05-25 17:11:42 +02:00
Feng Yu
b4398df2e5 tools: refactor build-addons.js to ESM 
PR-URL: https://github.com/nodejs/node/pull/43099
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-05-22 14:28:41 +01:00
Richard Lau
899753c034 build: run V8 tests with detected Python version 
V8's test runner now requires Python 3. Use the Python binary we
detected that is used elsewhere in the Makefile.

PR-URL: https://github.com/nodejs/node/pull/42740
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2022-04-21 11:56:01 +02:00
Maël Nison
e84b635db4 build: add corepack to the auto-updated dependencies 
PR-URL: https://github.com/nodejs/node/pull/42090
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
 2022-02-25 22:36:05 +00:00
Michael Dawson
a199387f04 doc: make contributing info more discoverable 
There are been several discussions in recent PRs about
the docs related to contributing not being very discoverable.
Move these docs from doc/guides/ to doc/contributing.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: https://github.com/nodejs/node/pull/41408
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2022-01-18 14:24:30 -05:00
Antoine du Hamel
f8f3d35bd6 tools: add missing .PHONY and .NOTPARALLEL targets in Makefile 
PR-URL: https://github.com/nodejs/node/pull/41515
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yash Ladha <yash@yashladha.in>
 2022-01-18 18:05:06 +00:00
Michaël Zasso
331b906195 build: fix npm version detection 
Npm's package.json now contains two fields named "version".
Grep for the top-level one.

Fixes: https://github.com/nodejs/build/issues/2850

PR-URL: https://github.com/nodejs/node/pull/41575
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2022-01-18 14:22:45 +01:00
alexcfyung
f6e5050579 build: start build on z/OS 
Update configure.py, Makefile, and common.gypi to get the
build started on z/OS.

Co-authored-by: Gaby Baghdadi <baghdadi@ca.ibm.com>
Co-authored-by: Wayne Zhang <zsw007@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/41273
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
 2022-01-06 15:54:32 +00:00
Rich Trott
ce66633b07 build: skip documentation generation if no ICU 
Closes: https://github.com/nodejs/node/issues/41077

PR-URL: https://github.com/nodejs/node/pull/41091
Fixes: https://github.com/nodejs/node/issues/41077
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-12-07 09:24:38 -08:00
Rich Trott
6dae965c2d tools: use jsdoc recommended rules 
Enable all recommended JSDoc linting rules and disable the ones we don't
(yet?) meet. They can be enabled one by one by removing the lines that
turn them off.

This requires adding --max-warnings to the ESLint invocations in
Makefile and vcbuild.bat because the preset enables the recommended
rules as warnings and not errors.

PR-URL: https://github.com/nodejs/node/pull/41057
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
 2021-12-04 19:04:05 -08:00
Rich Trott
a2572940cd build: remove legacy -J test.py option from Makefile/vcbuild 
PR-URL: https://github.com/nodejs/node/pull/40945
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2021-11-27 05:45:03 +00:00
Darshan Sen
ff536fa13e test: test crypto.setEngine() using an actual engine 
Signed-off-by: Darshan Sen <darshan.sen@postman.com>

PR-URL: https://github.com/nodejs/node/pull/40481
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-10-30 08:46:02 +00:00
Daniel Bevenius
66da32c045 deps,test,src,doc,tools: update to OpenSSL 3.0 
This pull request updates the OpenSSL version that is statically
linked with Node.js from OpenSSl 1.1.1 to quictls OpenSSL 3.0.0+quic.

This pull request will replace the OpenSSL version that is currently
in the deps directory and when performing a normal build
OpenSSL 3.0+quic will be statically linked to the Node.js executable.
We will still be able to dynamically link to OpenSSL 1.1.1 and we have
a CI job which dynamically links to OpenSSL 1.1.1 which is run for
every pull request to make sure that we maintain backward compatibility.

PR-URL: https://github.com/nodejs/node/pull/38512
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2021-10-11 06:28:08 +02:00
Chris Heisterkamp
5607de8c13 build: set DESTCPU correctly for 'make binary' on Apple Silicon 
PR-URL: https://github.com/nodejs/node/pull/40147
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2021-09-29 10:11:54 +00:00
Rich Trott
6077473111 tools: implement markdown formatting 
Markdown formatter is now available via `mark format-md` (or
`vcbuild format-md` on Windows).

PR-URL: https://github.com/nodejs/node/pull/40181
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
 2021-09-25 10:23:20 -07:00
Rich Trott
8d83c47029 tools: re-implement lint-md without unified-args 
`unified-args` ignores settings in the preset, expecting them to be in
remarkrc files or passed on the command line instead. Realizing that
we always send the same configuration options via the command-line
anyway, this removes `unified-args`. This means the preset settings are
now respected and it removes nearly 30000 lines of code in the resulting
rollup file.

I wasn't sure I was going to want to keep rollup so I started
re-implementing this without it, but ended up putting a minimal rollup
back as it still saves about 90000 lines of code vs. checking in
`node_modules`.

PR-URL: https://github.com/nodejs/node/pull/40180
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-09-25 03:51:52 +00:00
Rich Trott
18e527c32f build: add --no-user for pip commands in Makefile 
I ran into "Cannot combine --user and --target" in an environment and
adding --no-user seemed to fix it.

Refs: https://stackoverflow.com/a/67259534/436641

PR-URL: https://github.com/nodejs/node/pull/40169
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Christian Clauss <cclauss@me.com>
 2021-09-23 14:09:35 +00:00
Rich Trott
2b131a50e0 build: add YAML linting 
PR-URL: https://github.com/nodejs/node/pull/40007
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2021-09-07 13:54:10 +00:00
Maël Nison
46598b88bf deps: add corepack 
Corepack provides shims for Yarn and pnpm in order to soften the
developer experience when working on Node projects.

Refs: https://github.com/nodejs/node/issues/15244
Refs: https://github.com/nodejs/TSC/issues/904

PR-URL: https://github.com/nodejs/node/pull/39608
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-08-25 07:55:32 -07:00
Rich Trott
11109470b7 tools: fix markdown linting 
This updates remark-preset-lint-node to 3.0.1, which actually works
unlike the 3.0.0 version we're using. (Sorry about 3.0.0 not actually
linting!)

It also updates rollup and the rollup config. So this uses the
latest everything as of this writing.

PR-URL: https://github.com/nodejs/node/pull/39832
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-08-22 04:13:32 +00:00
legendecas
9b5aa8d99e build: override python executable path on configure 
PR-URL: https://github.com/nodejs/node/pull/39465
Fixes: https://github.com/nodejs/node/issues/39408
Fixes: https://github.com/nodejs/node/issues/39456
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
 2021-07-30 01:20:00 +08:00
Antoine du Hamel
ab73d95ace doc,tools: remove checkLinks.mjs 
The checks made by this are now integrated to `remark-preset-lint-node`,
there are no reason to keep it around anymore.

PR-URL: https://github.com/nodejs/node/pull/39206
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2021-07-23 09:38:35 +02:00
Richard Lau
7959b6d8e9 build: update coverage Makefile target comments 
Update the comments for the `coverage` Makefile target.
- Source files under `lib` are no longer instrumented since
d1dee495db
- Fix the name of the related CI job.

PR-URL: https://github.com/nodejs/node/pull/39365
Refs: https://github.com/nodejs/node/pull/25157
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-07-19 08:04:45 -07:00
Richard Lau
b60570ae59 build: update gcovr for gcc 8 compatibility 
Update the version of `gcovr` used for C++ coverage from 3.4 to 4.2 for
compatibility with gcc/g++ 8.

PR-URL: https://github.com/nodejs/node/pull/39326
Refs: https://github.com/nodejs/node/issues/39303
Refs: https://github.com/gcovr/gcovr/pull/228
Refs: https://github.com/nodejs/build/pull/2705
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-07-11 22:41:02 +00:00
LitoMore
5e32644b6f build: remove unused comment in Makefile 
PR-URL: https://github.com/nodejs/node/pull/39171
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-07-11 09:14:20 +02:00
Makoto Kato
0b27fd0856 build: allow to build riscv64 using Makefile 
PR-URL: https://github.com/nodejs/node/pull/39048
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2021-07-11 09:04:37 +02:00
legendecas
392213a387 node-api: cctest on v8impl::Reference 
PR-URL: https://github.com/nodejs/node/pull/38970
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com>
 2021-07-05 13:55:51 +08:00
Richard Lau
d65514bc29 build: don't pass --mode argument to V8 test-runner 
V8's test-runner dropped the `--mode` argument some time back, and now
produces the following error if run with it:
  run-tests.py: error: no such option: --mode

PR-URL: https://github.com/nodejs/node/pull/39055
Refs: https://github.com/nodejs/node/pull/35705
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-06-23 09:59:44 +00:00
Michaël Zasso
de01f475d5 tools: update doctool dependencies, migrate to ESM 
- Migrated to ESM because some dependencies now require it.
- Did not update `highlight.js` to v11 because it has many breaking
  changes.
- Used non-deprecated `highlight.js` API.

Refs: https://github.com/highlightjs/highlight.js/issues/2277
Fixes: https://github.com/nodejs/node/issues/38938
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/38966
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-06-14 08:22:00 -07:00
Richard Lau
889ad35d3d build: make build-addons errors fail the build 
The `build-addons` makefile target runs `tools/doc/addon-verify.js` and
then uses `touch` to update a timestamp file. Unconditionally calling
`touch` was losing the exit code from `tools/doc/addon-verify.js` so
any errors produced by that script were not failing the build.

PR-URL: https://github.com/nodejs/node/pull/38983
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-06-11 18:11:48 +00:00
Richard Lau
ff09d6de16 build: don't pass python override to V8 build 
If the `configure.py` script is executed by a Python binary that is
not the one on the PATH it will create a `python` symlink in
`out/tools/bin` and prefix that to the PATH so it is used instead of
the one that otherwise would have been found on the PATH. This is
done so that gyp scripts shelling out to `python` execute with the
same version of Python as used to run the configure script.

V8's build uses V8's build toolchain (i.e. not gyp) and currently that
is incompatible with Python 3. Prevent prefixing the PATH for the V8
build so that it picks up `python` from the unprefixed PATH. This will
allow us to build Node.js with Python 3 but still use Python 2 to build
V8 in the CI.

PR-URL: https://github.com/nodejs/node/pull/38969
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2021-06-09 12:43:23 +00:00
Issam E. Maghni
7afa7b9ab3 build: replace non-POSIX test -a|o 
test/[ from sbase unix tools[1] throws "too many arguments" if -a or
-o is provided. The syntax has been marked obsolescent as per the
manual[2].

[1] http://core.suckless.org/sbase/
[2] https://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html#tag_20_128_16

PR-URL: https://github.com/nodejs/node/pull/38731
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2021-05-21 15:47:16 -07:00
Rich Trott
3ef3501e49 test,debugger: migrate node-inspect tests to core 
Migrate the node-inspect tests to core (where node-inspect code now
lives) and remove node-inspect from deps directory.

PR-URL: https://github.com/nodejs/node/pull/38161
Refs: https://github.com/nodejs/node/discussions/36481
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2021-04-25 01:50:18 -07:00
Michaël Zasso
c3a5e15ebe build: default PYTHON to python3 in Makefile 
So that direct calls to `make` which spawn the configure script do not use Python 2.

PR-URL: https://github.com/nodejs/node/pull/37764
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ash Cripps <acripps@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2021-04-15 01:14:01 +00:00
Rich Trott
2853b76e20 build: add pummel tests to ci runs 
PR-URL: https://github.com/nodejs/node/pull/34289
Reviewed-By: Richard Lau <rlau@redhat.com>
 2021-04-10 15:18:10 -07:00
Ash Cripps
1d8c022544 build: update Makefile to support fat binary 
build a binary that is both x86_64 and arm64 on macos

PR-URL: https://github.com/nodejs/node/pull/37861
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2021-04-09 12:13:47 +01:00
Richard Lau
9cfb418e1f build: package release changelog for releases 
Package the changelog for the release line as `CHANGELOG.md` when
building a release binary tarball.

PR-URL: https://github.com/nodejs/node/pull/38033
Fixes: https://github.com/nodejs/node/issues/38025
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-04-07 12:26:34 -07:00
Antoine du Hamel
0afc8ac12e tools: add support for mjs and cjs JS snippet linting 
Refs: https://github.com/nodejs/node/pull/37162
Refs: https://github.com/nodejs/remark-preset-lint-node/pull/176

PR-URL: https://github.com/nodejs/node/pull/37311
Refs: https://github.com/eslint/eslint-plugin-markdown/pull/172
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2021-03-06 16:05:39 +01:00
cjihrig
934d3f05a3 tools: update eslint-plugin-markdown configuration 
This commit updates the linting setup to work with
eslint-plugin-markdown@2.0.0. This also allows the update-eslint
script to continue to function properly without changes.

PR-URL: https://github.com/nodejs/node/pull/37549
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2021-03-03 12:42:26 -05:00
Antoine du Hamel
910dec001d tools: run doctool tests on GitHub Actions CI 
PR-URL: https://github.com/nodejs/node/pull/37398
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-02-22 12:26:31 +01:00
Zijian Liu
2bb42bf156 tools,doc: list the stability status of each API 
Fixes: https://github.com/nodejs/node/issues/23723

PR-URL: https://github.com/nodejs/node/pull/36223
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-01-20 01:23:45 +01:00
raisinten
44cf49e376 build: refactor Makefile 
* add character classes
* replace echo -n with printf

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/36759
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-01-11 11:37:19 +01:00
Ruy Adorno
752991d27d build: fix make test-npm 
Fixes running npm tests with `make test-npm`

PR-URL: https://github.com/nodejs/node/pull/36369
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2020-12-14 22:50:12 +00:00
Antoine du Hamel
897307554a tools: remove bashisms from macOS release scripts 
PR-URL: https://github.com/nodejs/node/pull/36121
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2020-12-04 22:56:13 +00:00
raisinten
c12497ef12 build: fix typo in Makefile 
PR-URL: https://github.com/nodejs/node/pull/36176
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2020-11-27 17:19:13 +00:00
raisinten
2d167f0dc7 build: replace which with command -v 
PR-URL: https://github.com/nodejs/node/pull/36118
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2020-11-19 19:33:28 +01:00