himself65
2818fa6089
build: check if python is a executable program
...
After Windows 10 version 1903, placeholder files named "python.exe"
and "python3.exe" appear, not executable programs, and open the
MS Store when running without parameters.
Fixes: https://github.com/nodejs/node/issues/36694
Refs: https://devblogs.microsoft.com/python/python-in-the-windows-10-may-2019-update
PR-URL: https://github.com/nodejs/node/pull/36696
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2022-01-29 01:31:12 +00:00
David Sanders
79b21eead2
build,tools,win: trim unused VCBUILD_PYTHON_LOCATION variable
...
PR-URL: https://github.com/nodejs/node/pull/41235
Refs: https://github.com/nodejs/node/pull/18621
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
2022-01-06 15:24:36 +00:00
João Reis
d1d571e089
build: vcbuild uses default Python, not Py2
...
vcbuild now searches for the first python.exe found, and uses it, where
it used to look for Python 2 first.
PR-URL: https://github.com/nodejs/node/pull/30091
Reviewed-By: Christian Clauss <cclauss@me.com >
Reviewed-By: João Reis <reis@janeasystems.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2019-10-25 11:35:01 -07:00
João Reis
7bff96204b
build,win: fix Python detection on localized OS
...
This code previously assumed the default value was always printed to
the console by reg.exe as "(default)", but this is not true on
localized versions of Windows and can contain spaces.
Fixes: https://github.com/nodejs/node/issues/29417
PR-URL: https://github.com/nodejs/node/pull/29423
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Minwoo Jung <minwoo@nodesource.com >
Reviewed-By: David Carlier <devnexen@gmail.com >
2019-09-05 19:14:29 -07:00
João Reis
d18b6a7e40
build,win: accept Python 3 if 2 is not available
...
If there is no Python 2 available, use Python 3. This allows to test
running configure with Python 3.
PR-URL: https://github.com/nodejs/node/pull/29236
Reviewed-By: Christian Clauss <cclauss@me.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2019-09-02 21:07:08 -07:00
João Reis
eba72acada
build,win: find Python in paths with spaces
...
When looking for Python in the registry, as specified in PEP514,
this was not able to handle installations in a path with spaces,
like Program Files. This ensures the whole path is used, fixing the
issue.
PR-URL: https://github.com/nodejs/node/pull/29236
Reviewed-By: Christian Clauss <cclauss@me.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2019-09-02 21:07:06 -07:00
Guy Bedford
1d3e40d9aa
build: fix Python detection when depot_tools are in PATH in Windows
...
PR-URL: https://github.com/nodejs/node/pull/22539
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com >
Reviewed-By: Refael Ackermann <refack@gmail.com >
2018-11-21 13:02:28 -08:00
Kyle Farnung
988be43e33
tools,win: fix find_python error
...
On a machine without `python.exe` in the PATH the script was failing
with:
```console
> .\vcbuild.bat
Looking for Python 2.x
2> was unexpected at this time.
```
Escaping the `>` seems to resolve it.
PR-URL: https://github.com/nodejs/node/pull/22797
Reviewed-By: Richard Lau <riclau@uk.ibm.com >
Reviewed-By: Refael Ackermann <refack@gmail.com >
2018-09-17 16:50:47 -07:00
Bartosz Sosnowski
887a2ba92e
build, win: vcbuild improvements
...
Removes extra erroor messages when Python is not installed. Removes
"vswhere not found" message when no VS2017 installation is found.
Adds support for DEBUG_HELPER to vcbuild.bat.
Fixes: https://github.com/nodejs/node/issues/16864
PR-URL: https://github.com/nodejs/node/pull/17015
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
2018-02-22 12:43:35 +01:00
Jason Ginchereau
cee8d6d65e
build,win: fix python detection script
...
Handle spaces in the path to python.exe, in case it is installed
under some directory like "C:\Program Files".
PR-URL: https://github.com/nodejs/node/pull/14546
Reviewed-By: Timothy Gu <timothygu99@gmail.com >
Reviewed-By: Refael Ackermann <refack@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2017-08-01 10:56:04 -07:00
Refael Ackermann
614dbbd728
build,windows: implement PEP514 python detection
...
PR-URL: https://github.com/nodejs/node/pull/13900
Fixes: https://github.com/nodejs/node/issues/13882
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2017-06-28 11:46:24 -04:00
