Guy Fraser
a9387db867
debugger: use arrow function for lexical this
...
Refs: https://github.com/nodejs/node/issues/7414
PR-URL: https://github.com/nodejs/node/pull/7415
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Brian White <mscdex@mscdex.net >
2016-08-18 16:44:38 -07:00
Ben Noordhuis
c5c28c3d50
debugger: make listen address configurable
...
`--debug=1.2.3.4:5678` and `--debug=example.com:5678` are now accepted,
likewise the `--debug-brk` and `--debug-port` switch. The latter is
now something of a misnomer but it's undocumented and for internal use
only so it shouldn't matter too much.
`--inspect=1.2.3.4:5678` and `--inspect=example.com:5678` are also
accepted but don't use the host name yet; they still bind to the
default address.
Fixes: https://github.com/nodejs/node/issues/3306
PR-URL: https://github.com/nodejs/node/pull/3316
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Trevor Norris <trev.norris@gmail.com >
2016-06-30 13:41:51 +02:00
Jackson Tian
91466b855f
lib: refactor code with startsWith/endsWith
...
reduce using RegExp for string test. This pull reuqest replaces
various usages of regular expressions in favor of the ES2015
startsWith and endsWith methods.
PR-URL: https://github.com/nodejs/node/pull/5753
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Brian White <mscdex@mscdex.net >
2016-03-23 15:58:52 +02:00
Prince J Wesley
826844e27e
debugger: assert test before accessing this.binding
...
PR-URL: https://github.com/nodejs/node/pull/5145
Reviewed-By: Myles Borins <myles.borins@gmail.com >
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com >
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-02-10 08:28:30 -08:00
cjihrig
804e7aa9ab
lib: use const to define constants
...
This commit replaces a number of var statements throughout
the lib code with const statements.
PR-URL: https://github.com/iojs/io.js/pull/541
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
2015-01-21 16:21:31 -05:00
Vladimir Kurchatkin
9e62ae4304
_debug_agent: use readableObjectMode option
...
Use public `readableObjectMode` option to construct `Transform`
instead of accessing private `_readableState.objectMode`.
Partially addresses https://github.com/iojs/io.js/issues/445 .
PR-URL: https://github.com/iojs/io.js/pull/270
Reviewed-By: Fedor Indutny <fedor@indutny.com >
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Bert Belder <bertbelder@gmail.com >
Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com >
2015-01-15 11:10:48 -08:00
Ben Noordhuis
21130c7d6f
lib: turn on strict mode
...
Turn on strict mode for the files in the lib/ directory. It helps
catch bugs and can have a positive effect on performance.
PR-URL: https://github.com/node-forward/node/pull/64
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Fedor Indutny <fedor@indutny.com >
2014-11-22 17:23:30 +01:00
Ben Noordhuis
29d7fd6bb8
src: move debug agent from deps/ to src/
...
There is not much point in keeping it a separate project because it
doesn't build standalone, plus it makes applying changes to core more
difficult because of the implicit dependency on header files in src/.
2014-11-03 12:08:04 +01:00
