3 Commits

Author	SHA1	Message	Date
Darshan Sen	b5add9757d	tools: remove faulty early termination logic from update-timezone.mjs ... We do not build Node.js in the workflow so f4815fcd76/tools/update-timezone.mjs (L18) is actually the version of `tzdata` in the Node.js in the runner instead of what's in `main`. The script is pretty fast even when the versions differ and there is an update, so this optimization doesn't seem to be worth having given the problem. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: https://github.com/nodejs/node/pull/44870 Fixes: https://github.com/nodejs/node/issues/44865 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>	2022-10-10 15:23:50 +00:00
Darshan Sen	71e9bc1108	tools: fix timezone update tool ... The spawnSync call was previously silently failing with this error: ```sh icupkg: unable to open input file "icudt*.dat" ``` because spawnSync doesn't support globbing. This change replaces the spawnSync call with execSync because that supports globbing. I have tested this workflow with some minor modifications in my fork and I can confirm that it works as expected now. The bot opened this PR - https://github.com/RaisinTen/node/pull/2 which updates deps/icu-small/source/data/in/icudt71l.dat.bz2. Fixes: https://github.com/nodejs/node/issues/44865 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: https://github.com/nodejs/node/pull/44870 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>	2022-10-10 15:23:50 +00:00
Lenvin Gonsalves	85b46e1cab	tools: add timezone update workflow ... Fixes: https://github.com/nodejs/node/issues/43134 PR-URL: https://github.com/nodejs/node/pull/43988 Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>	2022-09-16 00:03:40 +02:00