Guy Bedford
1d3e40d9aa
build: fix Python detection when depot_tools are in PATH in Windows
...
PR-URL: https://github.com/nodejs/node/pull/22539
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com >
Reviewed-By: Refael Ackermann <refack@gmail.com >
2018-11-21 13:02:28 -08:00
Kyle Farnung
988be43e33
tools,win: fix find_python error
...
On a machine without `python.exe` in the PATH the script was failing
with:
```console
> .\vcbuild.bat
Looking for Python 2.x
2> was unexpected at this time.
```
Escaping the `>` seems to resolve it.
PR-URL: https://github.com/nodejs/node/pull/22797
Reviewed-By: Richard Lau <riclau@uk.ibm.com >
Reviewed-By: Refael Ackermann <refack@gmail.com >
2018-09-17 16:50:47 -07:00
Bartosz Sosnowski
887a2ba92e
build, win: vcbuild improvements
...
Removes extra erroor messages when Python is not installed. Removes
"vswhere not found" message when no VS2017 installation is found.
Adds support for DEBUG_HELPER to vcbuild.bat.
Fixes: https://github.com/nodejs/node/issues/16864
PR-URL: https://github.com/nodejs/node/pull/17015
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
2018-02-22 12:43:35 +01:00
Jason Ginchereau
cee8d6d65e
build,win: fix python detection script
...
Handle spaces in the path to python.exe, in case it is installed
under some directory like "C:\Program Files".
PR-URL: https://github.com/nodejs/node/pull/14546
Reviewed-By: Timothy Gu <timothygu99@gmail.com >
Reviewed-By: Refael Ackermann <refack@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2017-08-01 10:56:04 -07:00
Refael Ackermann
614dbbd728
build,windows: implement PEP514 python detection
...
PR-URL: https://github.com/nodejs/node/pull/13900
Fixes: https://github.com/nodejs/node/issues/13882
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2017-06-28 11:46:24 -04:00
