OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2026-01-15 12:15:26 +00:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity
44,965 Commits 30 Branches 683 Tags
2a99210ff7ee4c258efc4ebe2eefade7d8e17de0
Commit Graph

436 Commits

Author SHA1 Message Date
Rafael Gonzaga
6626b16dd8 doc: add RafaelGSS as performance strategic lead 
PR-URL: https://github.com/nodejs/node/pull/59445
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Ruy Adorno <ruy@vlt.sh>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
 2025-08-13 20:31:21 +00:00
James M Snell
31aacfa67c meta: clarify pr objection process further 
Based on some recent confusion around the objection
process for PRs, this commit adds some additional
clarification to the collaborator guide.

Specifically, it clarifies that:

* Objections must be made in the PR itself
* All objections are considered equal... no special
  additional weight is given to objections from TSC
  members.
* When mistakes happen and a PR lands despite having
  an unresolved objection, any revert or fixup PR
  is subject to the same regular objection process,
  albeit with a callout that fast-tracking is
  possible if uncontroversial.

PR-URL: https://github.com/nodejs/node/pull/59096
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Ruy Adorno <ruy@vlt.sh>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Stewart X Addison <sxa@redhat.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2025-08-06 14:30:52 +00:00
Jacob Smith
6d8aa55a2c doc: correct orthography eg. → e.g. 
PR-URL: https://github.com/nodejs/node/pull/59329
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
 2025-08-03 08:27:14 +00:00
Chengzhong Wu
7f37d39a87 node-api: reword "implementation in an alternative VM" as implementable 
PR-URL: https://github.com/nodejs/node/pull/59036
Fixes: https://github.com/nodejs/node/issues/58852
Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2025-08-01 16:58:49 +00:00
Rafael Gonzaga
698cbd0f8b benchmark: add calibrate-n script 
This script should help identify the best N
when creating/updating benchmarks

Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: https://github.com/nodejs/node/pull/59186
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2025-07-29 18:49:55 +00:00
Chengzhong Wu
450009db5c doc: avoid suggesting testing fast api with intense loop 
PR-URL: https://github.com/nodejs/node/pull/59111
Refs: https://github.com/nodejs/node/pull/59055
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Dario Piotrowicz <dario.piotrowicz@gmail.com>
 2025-07-21 11:59:15 +00:00
SeokHun
3983ef6e0d doc: fix typo in writing-test.md 
Corrects the misspelling of "optimial" to "optimal".

PR-URL: https://github.com/nodejs/node/pull/59123
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
 2025-07-21 11:17:30 +00:00
Dario Piotrowicz
0d14c954f9 doc: add new environment variables doc page 
add a new doc page for environment variables, this would be the
one-stop place for all evnrioment variables informations (often
referring to other doc pages)

the main purpose of this page would also to provide a standard
Node.js specification for `.env` files

PR-URL: https://github.com/nodejs/node/pull/59052
Fixes: https://github.com/nodejs/node/issues/58807
Reviewed-By: James M Snell <jasnell@gmail.com>
 2025-07-20 20:53:54 +00:00
Rafael Gonzaga
229cc3be28 doc: add RafaelGSS as steward July 25 
PR-URL: https://github.com/nodejs/node/pull/59078
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
 2025-07-16 09:16:52 +00:00
Antoine du Hamel
19876f492e doc: move "Core Promise APIs" to "Completed initiatives" 
PR-URL: https://github.com/nodejs/node/pull/58934
Fixes: https://github.com/nodejs/TSC/issues/1094
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
 2025-07-05 00:35:37 +02:00
Michael Dawson
560d00ffb7 doc: remove myself from security steward rotation 
Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: https://github.com/nodejs/node/pull/58927
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Ruy Adorno <ruy@vlt.sh>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
 2025-07-04 14:04:13 +00:00
James M Snell
ebe7dade03 doc: add guidelines for introduction of ERM support 
PR-URL: https://github.com/nodejs/node/pull/58526
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
 2025-06-29 13:54:00 +00:00
Antoine du Hamel
da079e0350 doc: update git node release example 
And add additional info for security releases.

PR-URL: https://github.com/nodejs/node/pull/58475
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ruy Adorno <ruy@vlt.sh>
 2025-05-28 19:14:26 +00:00
René
9239373b7a doc: remove remaining uses of @@wellknown syntax 
PR-URL: https://github.com/nodejs/node/pull/58413
Refs: https://github.com/tc39/ecma262/pull/1314
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
 2025-05-23 18:31:34 +00:00
Rafael Gonzaga
306c11fe0a doc: add latest security release steward 
PR-URL: https://github.com/nodejs/node/pull/58339
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
 2025-05-15 10:35:45 +00:00
Dario Piotrowicz
656bf7d0b8 doc: update commit-queue documentation 
update the commit-queue contributing documentation by:
 - removing the references of the feature being experimental
 - clarifying that it applies to mergeable pull requests

PR-URL: https://github.com/nodejs/node/pull/58275
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2025-05-13 12:10:36 +00:00
Filip Skokan
daced4ab98 buffer: move SlowBuffer to EOL 
This commits reverts da69d13623

PR-URL: https://github.com/nodejs/node/pull/58220
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2025-05-09 19:41:31 +00:00
Filip Skokan
da69d13623 Revert "buffer: move SlowBuffer to EOL" 
This reverts commit 647175ee0b.

PR-URL: https://github.com/nodejs/node/pull/58211
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
 2025-05-07 19:31:21 +00:00
Brian Muenzenmeyer
9148e965b4 doc: add ambassaor message 
PR-URL: https://github.com/nodejs/node/pull/57600
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
 2025-05-06 14:59:01 -04:00
Miguel Marcondes Filho
5ac126bbe6 doc: fix typo in benchmark script path 
PR-URL: https://github.com/nodejs/node/pull/58129
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
 2025-05-04 20:04:55 +00:00
Michaël Zasso
187fc5cc3a deps: remove deps/simdutf 
We depend on V8's version of simdutf now.

PR-URL: https://github.com/nodejs/node/pull/58070
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
 2025-05-02 15:10:36 +02:00
James M Snell
647175ee0b buffer: move SlowBuffer to EOL 
`SlowBuffer` has been deprecated for many years now. Let's remove it.

PR-URL: https://github.com/nodejs/node/pull/58008
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2025-04-27 07:40:37 -07:00
Sebastian Beltran
b92f77a094 doc: fix typo in writing-docs 
PR-URL: https://github.com/nodejs/node/pull/57776
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
 2025-04-08 19:30:54 +00:00
Antoine du Hamel
52425d2ee7 doc: update CI instructions 
The recent changes made to better protect CI against malicious PRs have
changed how the `Retry` button can be used, it will no longer be
useful when follow up commits were pushed due to the non-matching
commit SHA.

PR-URL: https://github.com/nodejs/node/pull/57743
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2025-04-06 14:31:29 +00:00
Chengzhong Wu
2ff6c7e523 doc: classify Chrome DevTools Protocol as tier 2 
Chrome DevTools Protocol is the de-facto debugger protocol for
Node.js and is tested regularly in Node.js test suite / CI. It matches
the tier 2 classification but lacks proper documentation in Node.js.

Classify the Chrome DevTools Protocol as tier 2 with a target of
tier 1 once we have proper documentation on stable protocols.

On the other hand, the Chrome DevTools Frontend is not shipped with
Node.js and not tested in Node.js CI. So keep it as tier 3.

PR-URL: https://github.com/nodejs/node/pull/57634
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2025-04-01 12:33:04 +00:00
Dario Piotrowicz
b4280ef72c doc: add section stating that very stale PRs should be closed 
PR-URL: https://github.com/nodejs/node/pull/57541
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2025-03-25 03:02:27 +00:00
Dario Piotrowicz
046781e266 doc: add new writing-docs contributing md 
PR-URL: https://github.com/nodejs/node/pull/57502
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2025-03-18 19:39:16 +00:00
Rafael Gonzaga
bd8f2ba0d2 doc: prefer to sign commits under nodejs repository 
PR-URL: https://github.com/nodejs/node/pull/57311
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
 2025-03-17 09:10:26 +00:00
letianpailove
8b41272f79 doc: fixed the incorrect splitting of multiple words 
PR-URL: https://github.com/nodejs/node/pull/57454
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2025-03-16 08:27:00 -07:00
Richard Lau
81d3db2250 doc: update maintaining-openssl.md for openssl 
Update the instructions for maintaining OpenSSL in the Node.js source
tree to reflect switching back from the quictls fork of OpenSSL back
to official OpenSSL.

PR-URL: https://github.com/nodejs/node/pull/57413
Refs: https://github.com/nodejs/node/pull/57301
Refs: https://github.com/nodejs/node/pull/57142
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2025-03-13 17:42:04 +00:00
Rafael Gonzaga
10ea7646d9 doc: add note about sync nodejs-private branches 
PR-URL: https://github.com/nodejs/node/pull/57404
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2025-03-12 20:47:26 +00:00
Michael Dawson
34975b3e61 doc: add info on how project manages social media 
Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: https://github.com/nodejs/node/pull/57318
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2025-03-10 10:53:04 -04:00
Darshan Sen
9325697379 meta: move RaisinTen back to collaborators, triagers and SEA champion 
Refs: https://github.com/nodejs/TSC/issues/1690
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/57292
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2025-03-07 14:52:43 +00:00
Rafael Gonzaga
ded4eca425 doc: ping nodejs/tsc for each security pull request 
Refs: https://github.com/nodejs/TSC/issues/1687
PR-URL: https://github.com/nodejs/node/pull/57309
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
 2025-03-06 12:52:04 +00:00
Chengzhong Wu
64f6a2fc4d doc: update node-api version matrix 
PR-URL: https://github.com/nodejs/node/pull/57287
Fixes: https://github.com/nodejs/node/issues/57284
Refs: https://github.com/nodejs/node/pull/55676
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2025-03-05 10:10:10 +00:00
Chengzhong Wu
f37d2a5809 tools: add more details about rolling inspector_protocol 
PR-URL: https://github.com/nodejs/node/pull/57167
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
 2025-03-04 12:13:28 +00:00
Samuel Bronson
4466e07540 doc: fix web.libera.chat link in pull-requests.md 
The old link wasn't prefilling the channel name for me,
and this is the format suggested in the docs:<https://libera.chat/guides/webchat#kiwiirc>

It works, too!

PR-URL: https://github.com/nodejs/node/pull/57076
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2025-02-23 19:32:19 +00:00
RafaelGSS
0a4572d6a7 build: add skip_apidoc_files and include QUIC 
PR-URL: https://github.com/nodejs/node/pull/56941
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2025-02-17 19:23:39 -08:00
Joyee Cheung
ff51d83c96 doc: recommend writing tests in new files and including comments 
The previous phrasing encouraged or did not discourage appending
new test cases to existing files - a practice that can reduce
the debuggability of the tests over time as they get bigger and
bigger, some times thousands of lines long with hundreds of
test cases, and make the CI output increasingly difficult to
read when one of the test cases fail in a very long test.

This patch updates the guideline to explicitly discourage appending
test cases this way. Also recommend including an opening comment
to describe what the test does to optimize the test towards the
scenario when it fails.

PR-URL: https://github.com/nodejs/node/pull/57028
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
 2025-02-15 12:58:08 +00:00
Rafael Gonzaga
5c83957601 doc: update cleanup to trust on vuln db automation 
Since https://github.com/nodejs-private/security-release/pull/56 this
process has been automated.

PR-URL: https://github.com/nodejs/node/pull/57004
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
 2025-02-13 14:20:14 +00:00
Jan Krems
f5353100be deps,tools: add zstd 1.5.6 
PR-URL: https://github.com/nodejs/node/pull/52100
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2025-02-08 12:43:52 +00:00
Rafael Gonzaga
436723282d doc: update post sec release process 
PR-URL: https://github.com/nodejs/node/pull/56907
Fixes: https://github.com/nodejs-private/security-release/issues/52
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
 2025-02-05 19:48:05 +00:00
Dario Piotrowicz
ce6a628720 doc: add note regarding commit message trailers 
Co-authored-by: Yagiz Nizipli <yagiz@nizipli.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/56736
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2025-01-26 01:30:11 +00:00
Rafael Gonzaga
a1c9c1a2dd doc: add RafaelGSS as latest sec release stewards 
PR-URL: https://github.com/nodejs/node/pull/56682
Refs: https://github.com/nodejs-private/security-release/pull/41
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2025-01-23 19:05:11 +00:00
Rafael Gonzaga
6f946c95b9 doc: mention prepare --security 
PR-URL: https://github.com/nodejs/node/pull/56617
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2025-01-17 21:50:56 +00:00
Michael Dawson
00d49649da doc: tweak info on reposts in ambassador program 
Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: https://github.com/nodejs/node/pull/56589
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
 2025-01-16 22:44:06 +00:00
Marco Ippolito
b3641fe85d doc: add type stripping to ambassadors program 
PR-URL: https://github.com/nodejs/node/pull/56598
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2025-01-16 17:26:55 +00:00
Antoine du Hamel
187007a5ec doc: document CLI way to open the nodejs/bluesky PR 
PR-URL: https://github.com/nodejs/node/pull/56506
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Ruy Adorno <ruy@vlt.sh>
 2025-01-13 21:39:25 +00:00
Rafael Gonzaga
649da3b837 doc: include CVE to EOL lines as sec release process 
Refs: https://github.com/nodejs/security-wg/issues/1401
PR-URL: https://github.com/nodejs/node/pull/56520
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
 2025-01-10 17:02:12 +00:00
Michael Dawson
2f35b1f175 doc: add message for Ambassadors to promote 
Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: https://github.com/nodejs/node/pull/56235
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2025-01-09 17:09:14 -05:00