Tobias Nießen
c2e4b1fa9a
crypto: remove ALPN_ENABLED
...
This constant was likely introduced for feature detection, but it has
been pointless for a long time.
1. I am not aware of any possible Node.js build configuration (on any
recent/supported release line) that would have crypto.constants but
not crypto.constants.ALPN_ENABLED.
2. There is no evidence of this constant being used for feature
detection in the ecosystem. In fact, both internal and external type
definitions for crypto.constants simply assume that the constant
exists.
3. There is no good reason for any modern TLS stack to not support ALPN.
It looks like ALPN might have been optional in much earlier versions
of OpenSSL, but all recent versions of OpenSSL unconditionally
support ALPN as far as I can tell.
Refs: https://github.com/nodejs/node/pull/46956
PR-URL: https://github.com/nodejs/node/pull/47028
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2023-03-13 14:11:35 +00:00
Antoine du Hamel
0c460518e8
typings: improve primordials typings
...
PR-URL: https://github.com/nodejs/node/pull/46970
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
2023-03-08 10:47:26 +00:00
Antoine du Hamel
e7f172c191
crypto: refactor ArrayBuffer to bigint conversion utils
...
PR-URL: https://github.com/nodejs/node/pull/45567
Refs: https://github.com/nodejs/performance/issues/16
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2022-11-27 18:27:21 +00:00
Daeyeon Jeong
deb7710a94
src: remove unused contextify_global_private_symbol
...
`contextify_global_private_symbol` is no longer used. It was used
to hold a new context's global object, but the approach has been
changed to hold a ContextifyContext wrapper using
`contextify_context_private_symbol`.
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/45128
Refs: https://github.com/nodejs/node/pull/44796
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
2022-10-24 18:17:19 +00:00
Ben Noordhuis
fdadea8f6e
src: optimize ALPN callback
...
It doesn't make sense from a performance perspective to retain an
arraybuffer with the ALPN byte string and look it up as a property on
the JS context object for every TLS handshake.
Store the byte string in the C++ TLSWrap object instead. That's both
a lot faster and a lot simpler.
PR-URL: https://github.com/nodejs/node/pull/44875
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2022-10-19 19:26:43 +00:00
Darshan Sen
42eb2e72de
src: use a typed array internally for process._exiting
...
This would prevent manual writes to the _exiting JS property on the
process object by passing the data directly via a typed array for
performance.
This change partially addresses this TODO:
3d575a4f1b/src/api/hooks.cc (L68-L71)
Signed-off-by: Darshan Sen <raisinten@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/43883
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
2022-07-31 07:32:00 +01:00
Gerhard Stöbich
da399a6c8e
async_hooks: remove destroyed symbol on Promises
...
Promises are never destroyed manually therefore it's not needed to
attach an object to track if destroy hook was called already.
PR-URL: https://github.com/nodejs/node/pull/42402
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
2022-03-21 20:35:05 +00:00
ExE Boss
c93ba41e48
typings: add types for symbol and accessor properties on primordials
...
PR-URL: https://github.com/nodejs/node/pull/40992
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-12-31 00:47:04 +01:00
Mestery
61a73f80c7
typings: add more bindings typings
...
PR-URL: https://github.com/nodejs/node/pull/40415
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2021-10-31 13:41:45 +01:00
Mestery
b66a75a3a4
typings: improve internal bindings typings
...
PR-URL: https://github.com/nodejs/node/pull/40411
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-10-28 07:52:29 +00:00
Mestery
a397009269
typings: separate internalBinding typings
...
PR-URL: https://github.com/nodejs/node/pull/40409
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com >
Reviewed-By: Qingyu Deng <i@ayase-lab.com >
2021-10-20 12:08:28 +00:00
Michaël Zasso
9467cbadcb
typings: define types for os binding
...
PR-URL: https://github.com/nodejs/node/pull/40222
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Evan Lucas <evanlucas@me.com >
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
2021-10-10 11:03:52 +02:00
Michaël Zasso
70a5b86049
typings: add missing types to options and util bindings
...
PR-URL: https://github.com/nodejs/node/pull/40222
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Evan Lucas <evanlucas@me.com >
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
2021-10-10 11:03:22 +02:00
Michaël Zasso
3815a21beb
typings: define types for timers binding
...
PR-URL: https://github.com/nodejs/node/pull/40222
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Evan Lucas <evanlucas@me.com >
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
2021-10-10 11:03:05 +02:00
Michaël Zasso
9e64336fbf
typings: fix declaration of primordials
...
PR-URL: https://github.com/nodejs/node/pull/40222
Fixes: https://github.com/nodejs/node/issues/40144
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Evan Lucas <evanlucas@me.com >
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
2021-10-10 11:02:45 +02:00
Michaël Zasso
281607d453
typings: define types for symbols binding
...
PR-URL: https://github.com/nodejs/node/pull/40143
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-09-26 10:42:11 +02:00
Michaël Zasso
0eb3420feb
typings: define types for worker and messaging bindings
...
PR-URL: https://github.com/nodejs/node/pull/40143
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-09-26 10:42:07 +02:00
James M Snell
fa0c6883a6
stream: implement WHATWG streams
...
Experimental implementation of the WHATWG streams standard.
Signed-off-by: James M Snell <jasnell@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/39062
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2021-06-30 12:54:41 -07:00
Michaël Zasso
b87f1be92d
typings: add types for "http_parser" and "options" bindings
...
PR-URL: https://github.com/nodejs/node/pull/38239
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Daniele Belardi <dwon.dnl@gmail.com >
2021-04-18 11:09:57 +02:00
Michaël Zasso
1c8b2956d1
typings: add types for internalBinding('serdes')
...
PR-URL: https://github.com/nodejs/node/pull/38204
Reviewed-By: Bradley Farias <bradley.meck@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-04-18 11:05:19 +02:00
Michaël Zasso
3377eb9641
typings: add types for internalBinding('util')
...
PR-URL: https://github.com/nodejs/node/pull/38200
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Bradley Farias <bradley.meck@gmail.com >
2021-04-14 12:32:26 +02:00
Michaël Zasso
cb2bdc632a
typings: add types for internalBinding('fs')
...
PR-URL: https://github.com/nodejs/node/pull/38198
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Bradley Farias <bradley.meck@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2021-04-14 12:24:23 +02:00
Bradley Farias
656fb4657a
lib: add tsconfig for code completions
...
PR-URL: https://github.com/nodejs/node/pull/38042
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com >
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2021-04-08 08:35:09 -05:00