Anna Henningsen
7be5f58638
tools: fix mkcodecache when run with ASAN
...
Fixes: https://github.com/nodejs/node/issues/32835
PR-URL: https://github.com/nodejs/node/pull/32850
Reviewed-By: Matheus Marchini <mat@mmarchini.me >
Reviewed-By: Richard Lau <riclau@uk.ibm.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
2020-04-22 00:40:40 +00:00
Joyee Cheung
192cb7288a
tools: use per-process native Debug() printer in mkcodecache
...
PR-URL: https://github.com/nodejs/node/pull/31884
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2020-03-10 05:52:39 +08:00
Ben Noordhuis
5116a6a9b4
tools: make code cache and snapshot deterministic
...
Use a fixed random seed to ensure that the generated sources are
identical across runs.
The final node binary still reseeds itself on start-up so there should
be no security implications caused by predictable random numbers (e.g.,
`Math.random()`, ASLR, the hash seed, etc.)
Fixes: https://github.com/nodejs/node/issues/29108
PR-URL: https://github.com/nodejs/node/pull/29142
Reviewed-By: Gus Caplan <me@gus.host >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2019-08-19 18:03:37 -07:00
Ben Noordhuis
a88700abd5
tools: fix use-after-free mkcodecache warning
...
Call `v8::Platform::ShutdownPlatform()` to fix a Coverity warning about
the `v8::Platform` instance being deleted when it's still in use.
PR-URL: https://github.com/nodejs/node/pull/27332
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Richard Lau <riclau@uk.ibm.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2019-04-24 10:22:50 +02:00
Joyee Cheung
4fd7193579
tools: implement mkcodecache as an executable
...
This patch implement a mkcodecache executable on top of the
`NativeModuleLoader` singleton.
This makes it possible to build a Node.js binary with embedded
code cache without building itself using the code cache stub -
the cache is now initialized by `NativeModuleEnv` instead which
can be refactored out of the mkcodecache dependencies.
PR-URL: https://github.com/nodejs/node/pull/27161
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
2019-04-16 18:23:32 -04:00
