diff --git a/doc/api/assert.md b/doc/api/assert.md index dffde2ac54..3fb67cb8d1 100644 --- a/doc/api/assert.md +++ b/doc/api/assert.md @@ -2594,9 +2594,13 @@ argument. added: - v23.4.0 - v22.13.0 +changes: + - version: REPLACEME + pr-url: https://github.com/nodejs/node/pull/57370 + description: partialDeepStrictEqual is now Stable. Previously, it had been Experimental. --> -> Stability: 1.2 - Release candidate +> Stability: 2 - Stable * `actual` {any} * `expected` {any} diff --git a/lib/assert.js b/lib/assert.js index c0c4f026e6..657ac6225d 100644 --- a/lib/assert.js +++ b/lib/assert.js @@ -54,7 +54,7 @@ const { isPromise, isRegExp, } = require('internal/util/types'); -const { isError, deprecate, emitExperimentalWarning } = require('internal/util'); +const { isError, deprecate } = require('internal/util'); const { innerOk } = require('internal/assert/utils'); const CallTracker = require('internal/assert/calltracker'); @@ -358,7 +358,6 @@ assert.partialDeepStrictEqual = function partialDeepStrictEqual( expected, message, ) { - emitExperimentalWarning('assert.partialDeepStrictEqual'); if (arguments.length < 2) { throw new ERR_MISSING_ARGS('actual', 'expected'); } diff --git a/test/parallel/test-assert-typedarray-deepequal.js b/test/parallel/test-assert-typedarray-deepequal.js index 403cd6748d..7fb18c1886 100644 --- a/test/parallel/test-assert-typedarray-deepequal.js +++ b/test/parallel/test-assert-typedarray-deepequal.js @@ -101,15 +101,10 @@ suite('notEqualArrayPairs', () => { makeBlock(assert.deepStrictEqual, arrayPair[0], arrayPair[1]), assert.AssertionError ); - // TODO(puskin94): remove emitWarning override once the partialDeepStrictEqual method is not experimental anymore - // Suppress warnings, necessary otherwise the tools/pseudo-tty.py runner will fail - const originalEmitWarning = process.emitWarning; - process.emitWarning = () => {}; assert.throws( makeBlock(assert.partialDeepStrictEqual, arrayPair[0], arrayPair[1]), assert.AssertionError ); - process.emitWarning = originalEmitWarning; // Restore original process.emitWarning }); } }); diff --git a/test/pseudo-tty/test-assert-colors.js b/test/pseudo-tty/test-assert-colors.js index 889e9a6e00..846326a9c4 100644 --- a/test/pseudo-tty/test-assert-colors.js +++ b/test/pseudo-tty/test-assert-colors.js @@ -1,4 +1,3 @@ -// Flags: --no-warnings 'use strict'; require('../common'); const assert = require('assert').strict; diff --git a/test/pseudo-tty/test-assert-no-color.js b/test/pseudo-tty/test-assert-no-color.js index c2e79d2670..d6765d6f06 100644 --- a/test/pseudo-tty/test-assert-no-color.js +++ b/test/pseudo-tty/test-assert-no-color.js @@ -1,4 +1,3 @@ -// Flags: --no-warnings 'use strict'; require('../common'); const assert = require('assert').strict;