From ad07ae6ac2293fe5261c2150be0b55a82cb10b70 Mon Sep 17 00:00:00 2001 From: Joyee Cheung Date: Fri, 25 Jul 2025 16:54:55 +0200 Subject: [PATCH] test: remove timeout in test-https-proxy-request-handshake-failure The timeout is unnecessary since we are testing for certificate failure. It can cause flakes on very slow machines where the request cannot be finished in 1 second. PR-URL: https://github.com/nodejs/node/pull/59165 Fixes: https://github.com/nodejs/node/issues/59166 Reviewed-By: James M Snell Reviewed-By: Chemi Atlow Reviewed-By: Moshe Atlow Reviewed-By: Luigi Pinca --- test/client-proxy/test-https-proxy-request-handshake-failure.mjs | 1 - 1 file changed, 1 deletion(-) diff --git a/test/client-proxy/test-https-proxy-request-handshake-failure.mjs b/test/client-proxy/test-https-proxy-request-handshake-failure.mjs index df6bc446fe..251d136afa 100644 --- a/test/client-proxy/test-https-proxy-request-handshake-failure.mjs +++ b/test/client-proxy/test-https-proxy-request-handshake-failure.mjs @@ -33,7 +33,6 @@ const requestUrl = `https://${serverHost}/test`; const { code, signal, stderr, stdout } = await runProxiedRequest({ NODE_USE_ENV_PROXY: 1, REQUEST_URL: requestUrl, - REQUEST_TIMEOUT: 1000, HTTPS_PROXY: `http://localhost:${proxy.address().port}`, });