From 84aeeff06a8401eb2b41874e86ec7a488d545e34 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Mon, 11 Mar 2024 10:30:53 +0000 Subject: [PATCH] deps: silence internal V8 deprecation warning PR-URL: https://github.com/nodejs/node/pull/52293 Reviewed-By: Moshe Atlow Reviewed-By: Rafael Gonzaga Reviewed-By: Richard Lau PR-URL: https://github.com/nodejs/node/pull/52465 Reviewed-By: Matteo Collina Reviewed-By: Michael Dawson --- common.gypi | 2 +- deps/v8/src/base/optional.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/common.gypi b/common.gypi index a5e5df7873..18f60c1435 100644 --- a/common.gypi +++ b/common.gypi @@ -37,7 +37,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.6', + 'v8_embedder_string': '-node.7', ##### V8 defaults for Node.js ##### diff --git a/deps/v8/src/base/optional.h b/deps/v8/src/base/optional.h index 6ad1b6f742..26ce838442 100644 --- a/deps/v8/src/base/optional.h +++ b/deps/v8/src/base/optional.h @@ -16,7 +16,7 @@ namespace base { // These aliases are deprecated, use std::optional directly. template -using Optional [[deprecated]] = std::optional; +using Optional = std::optional; using std::in_place; using std::make_optional;