From 77607d5306c1823b5c09a7d58d7a66e148626d13 Mon Sep 17 00:00:00 2001
From: Ruben Bridgewater <ruben.bridgewater@datadoghq.com>
Date: Sat, 8 Mar 2025 18:01:04 +0100
Subject: [PATCH] benchmark: adjust assert runtimes
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Each file should have a reasonable runtime while having a good
accuracy. This adjust those up and down to have minimal runtimes
with a good accuracy.

PR-URL: https://github.com/nodejs/node/pull/57370
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
---
 benchmark/assert/assertion-error.js                | 5 ++---
 benchmark/assert/deepequal-map.js                  | 2 +-
 benchmark/assert/deepequal-object.js               | 4 ++--
 benchmark/assert/deepequal-set.js                  | 2 +-
 benchmark/assert/deepequal-simple-array-and-set.js | 2 +-
 benchmark/assert/deepequal-typedarrays.js          | 6 ++++++
 6 files changed, 13 insertions(+), 8 deletions(-)

diff --git a/benchmark/assert/assertion-error.js b/benchmark/assert/assertion-error.js
index 1e70a70805..51fb52ae1a 100644
--- a/benchmark/assert/assertion-error.js
+++ b/benchmark/assert/assertion-error.js
@@ -3,9 +3,8 @@ const common = require('../common.js');
 const assert = require('assert');
 
 const bench = common.createBenchmark(main, {
-  n: [10, 50, 200, 500],
-  size: [10, 100],
-  datasetName: ['objects'],
+  n: [200],
+  size: [2, 75],
 });
 
 const baseObject = {
diff --git a/benchmark/assert/deepequal-map.js b/benchmark/assert/deepequal-map.js
index fb3f7cd316..4f651551c5 100644
--- a/benchmark/assert/deepequal-map.js
+++ b/benchmark/assert/deepequal-map.js
@@ -5,7 +5,7 @@ const { deepEqual, deepStrictEqual, notDeepEqual, notDeepStrictEqual } =
   require('assert');
 
 const bench = common.createBenchmark(main, {
-  n: [5e3],
+  n: [2e3],
   len: [5e2],
   strict: [0, 1],
   method: [
diff --git a/benchmark/assert/deepequal-object.js b/benchmark/assert/deepequal-object.js
index c480faf10c..e1d1baf838 100644
--- a/benchmark/assert/deepequal-object.js
+++ b/benchmark/assert/deepequal-object.js
@@ -4,12 +4,12 @@ const common = require('../common.js');
 const assert = require('assert');
 
 const bench = common.createBenchmark(main, {
-  n: [25, 2e2],
+  n: [50, 2e2],
   size: [1e2, 1e4],
   method: ['deepEqual', 'notDeepEqual', 'deepStrictEqual', 'notDeepStrictEqual'],
 }, {
   combinationFilter: (p) => {
-    return p.size === 1e4 && p.n === 25 ||
+    return p.size === 1e4 && p.n === 50 ||
            p.size === 1e3 && p.n === 2e2 ||
            p.size === 1e2 && p.n === 2e3 ||
            p.size === 1;
diff --git a/benchmark/assert/deepequal-set.js b/benchmark/assert/deepequal-set.js
index 27ca7c92bc..e771c81928 100644
--- a/benchmark/assert/deepequal-set.js
+++ b/benchmark/assert/deepequal-set.js
@@ -5,7 +5,7 @@ const { deepEqual, deepStrictEqual, notDeepEqual, notDeepStrictEqual } =
   require('assert');
 
 const bench = common.createBenchmark(main, {
-  n: [5e2],
+  n: [1e3],
   len: [5e2],
   strict: [0, 1],
   method: [
diff --git a/benchmark/assert/deepequal-simple-array-and-set.js b/benchmark/assert/deepequal-simple-array-and-set.js
index a1f6820696..08bbc87a1c 100644
--- a/benchmark/assert/deepequal-simple-array-and-set.js
+++ b/benchmark/assert/deepequal-simple-array-and-set.js
@@ -5,7 +5,7 @@ const { deepEqual, deepStrictEqual, notDeepEqual, notDeepStrictEqual } =
   require('assert');
 
 const bench = common.createBenchmark(main, {
-  n: [5e2],
+  n: [1e3],
   len: [1e4],
   strict: [1],
   method: [
diff --git a/benchmark/assert/deepequal-typedarrays.js b/benchmark/assert/deepequal-typedarrays.js
index 86826d6588..5684cd520d 100644
--- a/benchmark/assert/deepequal-typedarrays.js
+++ b/benchmark/assert/deepequal-typedarrays.js
@@ -16,6 +16,12 @@ const bench = common.createBenchmark(main, {
     'notDeepEqual',
   ],
   len: [1e2, 5e3],
+}, {
+  combinationFilter(p) {
+    return p.strict === 1 ||
+           p.type !== 'Float32Array' ||
+           p.len === 1e2;
+  },
 });
 
 function main({ type, n, len, method, strict }) {