From 73b50220c70e8167cda17de9b262413cebcb3d3d Mon Sep 17 00:00:00 2001 From: Robert Nagy Date: Mon, 8 Sep 2025 11:27:29 +0200 Subject: [PATCH] http: use cached '1.1' http version string PR-URL: https://github.com/nodejs/node/pull/59717 Reviewed-By: Trivikram Kamat Reviewed-By: Tim Perry Reviewed-By: Matteo Collina Reviewed-By: Ethan Arrowood --- lib/_http_common.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/_http_common.js b/lib/_http_common.js index 0cbc5ba0ec..ae4cc39bef 100644 --- a/lib/_http_common.js +++ b/lib/_http_common.js @@ -64,6 +64,8 @@ function parserOnHeaders(headers, url) { this._url += url; } +const HTTP_VERSION_1_1 = '1.1'; + // `headers` and `url` are set only if .onHeaders() has not been called for // this request. // `url` is not set for response parsers but that's not applicable here since @@ -91,7 +93,9 @@ function parserOnHeadersComplete(versionMajor, versionMinor, headers, method, const incoming = parser.incoming = new ParserIncomingMessage(socket); incoming.httpVersionMajor = versionMajor; incoming.httpVersionMinor = versionMinor; - incoming.httpVersion = `${versionMajor}.${versionMinor}`; + incoming.httpVersion = versionMajor === 1 && versionMinor === 1 ? + HTTP_VERSION_1_1 : + `${versionMajor}.${versionMinor}`; incoming.joinDuplicateHeaders = socket?.server?.joinDuplicateHeaders || parser.joinDuplicateHeaders; incoming.url = url;