mirror of
https://github.com/zebrajr/node.git
synced 2026-01-15 12:15:26 +00:00
test: use assert.match instead of regexp.test
PR-URL: https://github.com/nodejs/node/pull/39928 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
This commit is contained in:
@@ -142,7 +142,7 @@ TEST(function test_lookup_ipv6_hint(done) {
|
||||
assert(err instanceof Error);
|
||||
assert.strictEqual(err.code, 'EAI_BADFLAGS');
|
||||
assert.strictEqual(err.hostname, addresses.INET_HOST);
|
||||
assert.ok(/getaddrinfo EAI_BADFLAGS/.test(err.message));
|
||||
assert.match(err.message, /getaddrinfo EAI_BADFLAGS/);
|
||||
done();
|
||||
return;
|
||||
}
|
||||
|
||||
@@ -527,7 +527,7 @@ TEST(function test_lookup_failure(done) {
|
||||
assert.ok(err instanceof Error);
|
||||
assert.strictEqual(err.code, dns.NOTFOUND);
|
||||
assert.strictEqual(err.code, 'ENOTFOUND');
|
||||
assert.ok(!/ENOENT/.test(err.message));
|
||||
assert.doesNotMatch(err.message, !/ENOENT/);
|
||||
assert.ok(err.message.includes(addresses.NOT_FOUND));
|
||||
|
||||
done();
|
||||
@@ -640,7 +640,7 @@ TEST(function test_lookupservice_invalid(done) {
|
||||
const req = dns.lookupService('1.2.3.4', 80, (err) => {
|
||||
assert(err instanceof Error);
|
||||
assert.strictEqual(err.code, 'ENOTFOUND');
|
||||
assert.ok(/1\.2\.3\.4/.test(err.message));
|
||||
assert.match(err.message, /1\.2\.3\.4/);
|
||||
|
||||
done();
|
||||
});
|
||||
@@ -662,7 +662,7 @@ TEST(function test_reverse_failure(done) {
|
||||
assert(err instanceof Error);
|
||||
assert.strictEqual(err.code, 'ENOTFOUND'); // Silly error code...
|
||||
assert.strictEqual(err.hostname, '203.0.113.0');
|
||||
assert.ok(/203\.0\.113\.0/.test(err.message));
|
||||
assert.match(err.message, /203\.0\.113\.0/);
|
||||
|
||||
done();
|
||||
});
|
||||
|
||||
@@ -28,7 +28,7 @@ function check(url, cb) {
|
||||
});
|
||||
|
||||
res.on('end', common.mustCall(() => {
|
||||
assert(/>Debugging Guide</.test(result));
|
||||
assert.match(result, />Debugging Guide</);
|
||||
cb();
|
||||
}));
|
||||
})).on('error', common.mustNotCall);
|
||||
|
||||
Reference in New Issue
Block a user