From 49d6026fd1dc944c6b83c5817f90bf45ee959f41 Mon Sep 17 00:00:00 2001 From: Nikita Skovoroda Date: Fri, 14 Nov 2025 00:21:17 +0300 Subject: [PATCH] test: fix test-buffer-zero-fill-cli to be effective PR-URL: https://github.com/nodejs/node/pull/60623 Reviewed-By: Rafael Gonzaga Reviewed-By: Luigi Pinca Reviewed-By: Colin Ihrig --- test/parallel/test-buffer-zero-fill-cli.js | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/test/parallel/test-buffer-zero-fill-cli.js b/test/parallel/test-buffer-zero-fill-cli.js index 663911b718..196362c55f 100644 --- a/test/parallel/test-buffer-zero-fill-cli.js +++ b/test/parallel/test-buffer-zero-fill-cli.js @@ -14,6 +14,13 @@ function isZeroFilled(buf) { return true; } +// We have to consume the data from the pool as otherwise +// we would be testing what's in snapshot, which is zero-filled +// regardless of the flag presence, and we want to test the flag +for (let i = 0; i < 8; i++) { + assert(isZeroFilled(Buffer.allocUnsafe(1024))); +} + // This can be somewhat unreliable because the // allocated memory might just already happen to // contain all zeroes. The test is run multiple @@ -22,7 +29,8 @@ for (let i = 0; i < 50; i++) { const bufs = [ Buffer.alloc(20), Buffer.allocUnsafe(20), - Buffer.allocUnsafeSlow(20), + Buffer.allocUnsafeSlow(20), // Heap + Buffer.allocUnsafeSlow(128), // Alloc Buffer(20), ]; for (const buf of bufs) {