From 32a8cc0ba525446ecba49160dc5c01c6d5ceb3b7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Tue, 6 May 2025 10:00:25 +0200 Subject: [PATCH] Revert "deps: disable V8 concurrent sparkplug compilation" This reverts commit 57699fffb8a387a3edeafd3418a369907b6b8246. PR-URL: https://github.com/nodejs/node/pull/58187 Reviewed-By: Ben Noordhuis Reviewed-By: James M Snell Reviewed-By: Rafael Gonzaga Reviewed-By: Luigi Pinca --- common.gypi | 2 +- deps/v8/src/flags/flag-definitions.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/common.gypi b/common.gypi index 93b20503c4..e991903625 100644 --- a/common.gypi +++ b/common.gypi @@ -38,7 +38,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.10', + 'v8_embedder_string': '-node.11', ##### V8 defaults for Node.js ##### diff --git a/deps/v8/src/flags/flag-definitions.h b/deps/v8/src/flags/flag-definitions.h index ab649fc717..dd713090c6 100644 --- a/deps/v8/src/flags/flag-definitions.h +++ b/deps/v8/src/flags/flag-definitions.h @@ -1106,7 +1106,7 @@ DEFINE_BOOL(baseline_batch_compilation, true, "batch compile Sparkplug code") DEFINE_BOOL_READONLY(concurrent_sparkplug, false, "compile Sparkplug code in a background thread") #else -DEFINE_BOOL(concurrent_sparkplug, false, +DEFINE_BOOL(concurrent_sparkplug, ENABLE_SPARKPLUG_BY_DEFAULT, "compile Sparkplug code in a background thread") DEFINE_WEAK_IMPLICATION(future, concurrent_sparkplug) DEFINE_NEG_IMPLICATION(predictable, concurrent_sparkplug)