mirror of
https://github.com/zebrajr/node.git
synced 2026-01-15 12:15:26 +00:00
buffer: fix check for .buffer property
isSharedArrayBuffer in fromObject was missing obj.buffer moved the 'length' in obj check so that it is checked first making the code slightly more performant and able to handle SharedArrayBuffer without relying on an explicit check. Ref: https://github.com/nodejs/node/pull/8510 PR-URL: https://github.com/nodejs/node/pull/8739 Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This commit is contained in:
committed by
Anna Henningsen
parent
647e8e5ae4
commit
2154bc89d8
@@ -27,3 +27,5 @@ assert.deepStrictEqual(arr_buf, ar_buf, 0);
|
||||
// Checks for calling Buffer.byteLength on a SharedArrayBuffer
|
||||
|
||||
assert.strictEqual(Buffer.byteLength(sab), sab.byteLength, 0);
|
||||
|
||||
assert.doesNotThrow(() => Buffer.from({buffer: sab}));
|
||||
|
||||
Reference in New Issue
Block a user