From 12ae33476a69a3b13477ffd60a7497088e769870 Mon Sep 17 00:00:00 2001 From: Joyee Cheung Date: Sat, 3 Feb 2018 17:30:48 +0800 Subject: [PATCH] util: skip type checks in internal getSystemErrorName PR-URL: https://github.com/nodejs/node/pull/18546 Reviewed-By: James M Snell --- lib/internal/util.js | 8 -------- lib/util.js | 13 ++++++++++++- 2 files changed, 12 insertions(+), 9 deletions(-) diff --git a/lib/internal/util.js b/lib/internal/util.js index 1e48eedfd5..3de8090cfa 100644 --- a/lib/internal/util.js +++ b/lib/internal/util.js @@ -221,14 +221,6 @@ function getConstructorOf(obj) { } function getSystemErrorName(err) { - if (typeof err !== 'number') { - throw new errors.TypeError('ERR_INVALID_ARG_TYPE', 'err', 'number', err); - } - if (err >= 0 || !Number.isSafeInteger(err)) { - throw new errors.RangeError('ERR_OUT_OF_RANGE', 'err', - 'a negative integer', err); - } - const entry = errmap.get(err); return entry ? entry[0] : `Unknown system error ${err}`; } diff --git a/lib/util.js b/lib/util.js index 4525792b2e..14c99bd454 100644 --- a/lib/util.js +++ b/lib/util.js @@ -55,7 +55,7 @@ const { const { customInspectSymbol, deprecate, - getSystemErrorName, + getSystemErrorName: internalErrorName, getIdentificationOf, isError, promisify, @@ -1139,6 +1139,17 @@ function callbackify(original) { return callbackified; } +function getSystemErrorName(err) { + if (typeof err !== 'number') { + throw new errors.TypeError('ERR_INVALID_ARG_TYPE', 'err', 'number', err); + } + if (err >= 0 || !Number.isSafeInteger(err)) { + throw new errors.RangeError('ERR_OUT_OF_RANGE', 'err', + 'a negative integer', err); + } + return internalErrorName(err); +} + // Keep the `exports =` so that various functions can still be monkeypatched module.exports = exports = { _errnoException,