From 0c1fb986a01c492c681bdb145ca5cba3df2dff3d Mon Sep 17 00:00:00 2001 From: Dario Piotrowicz Date: Sun, 5 Oct 2025 18:57:01 +0100 Subject: [PATCH] tools: add message on auto-fixing js lint issues in gh workflow PR-URL: https://github.com/nodejs/node/pull/59128 Reviewed-By: Luigi Pinca Reviewed-By: Marco Ippolito Reviewed-By: James M Snell Reviewed-By: Antoine du Hamel --- .github/workflows/linters.yml | 26 +++++++++++++++++++++++++- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/.github/workflows/linters.yml b/.github/workflows/linters.yml index b258df0392..8ef41b0a20 100644 --- a/.github/workflows/linters.yml +++ b/.github/workflows/linters.yml @@ -103,7 +103,31 @@ jobs: - name: Environment Information run: npx envinfo - name: Lint JavaScript files - run: NODE=$(command -v node) make lint-js + run: | + set +e + NODE=$(command -v node) make lint-js + EXIT_CODE="$?" + if [ "$EXIT_CODE" != "0" ]; then + echo + echo 'ERROR: The JavaScript lint validation failed (the errors are logged above).' + echo ' Please fix the lint errors.' + if NODE=$(command -v node) make lint-js-fix > /dev/null 2>&1; then + echo ' Run:' + echo ' make lint-js-fix' + echo ' to fix the lint issues.' + git --no-pager diff + elif git diff --quiet --exit-code; then + echo ' None of the issue is auto-fixable, so manual fixes for' + echo ' all of the issues are required.' + else + echo ' Run:' + echo ' make lint-js-fix' + echo ' to fix the auto-fixable lint issues.' + echo ' Note that some manual fixes are also required.' + fi + echo + exit "$EXIT_CODE" + fi - name: Get release version numbers if: ${{ github.event.pull_request && github.event.pull_request.base.ref == github.event.pull_request.base.repo.default_branch }} id: get-released-versions