From efbe1779e370a8cd7409dde569607e5e1e818f2c Mon Sep 17 00:00:00 2001 From: Blake Embrey Date: Mon, 17 Mar 2014 15:01:04 -0300 Subject: [PATCH] Override params every layer. --- lib/router/index.js | 6 +----- test/Router.js | 1 - test/app.use.js | 4 ++-- 3 files changed, 3 insertions(+), 8 deletions(-) diff --git a/lib/router/index.js b/lib/router/index.js index b528df25..74183e20 100644 --- a/lib/router/index.js +++ b/lib/router/index.js @@ -183,11 +183,7 @@ proto.handle = function(req, res, done) { } } - req.params = req.params || {}; - - for (var key in layer.params) { - req.params[key] = layer.params[key]; - } + req.params = layer.params; // this should be done for the layer return self.process_params(layer, req, res, function(err) { diff --git a/test/Router.js b/test/Router.js index 8f8ff44d..c2058c5b 100644 --- a/test/Router.js +++ b/test/Router.js @@ -34,7 +34,6 @@ describe('Router', function(){ var another = new Router(); another.get('/:bar', function(req, res){ - req.params.foo.should.equal('test'); req.params.bar.should.equal('route'); res.end(); }); diff --git a/test/app.use.js b/test/app.use.js index 074a08c9..6ebd4eda 100644 --- a/test/app.use.js +++ b/test/app.use.js @@ -69,14 +69,14 @@ describe('app', function(){ , app = express(); blog.get('/', function(req, res){ - res.end(req.params.article); + res.end('success'); }); app.use('/post/:article', blog); request(app) .get('/post/once-upon-a-time') - .expect('once-upon-a-time', done); + .expect('success', done); }) }) })