diff --git a/History.md b/History.md index 1bea61a7..7f522d1a 100644 --- a/History.md +++ b/History.md @@ -3,6 +3,8 @@ This incorporates all changes after 4.14.1 up to 4.15.0. + * remove: + - Remove Express 3.x middleware error stubs * deps: router@~1.3.0 - Add `next("router")` to exit from router - Fix case where `router.use` skipped requests routes did not diff --git a/lib/express.js b/lib/express.js index 04dde09d..688f4295 100644 --- a/lib/express.js +++ b/lib/express.js @@ -74,37 +74,3 @@ exports.Router = Router; */ exports.static = require('serve-static'); - -/** - * Replace removed middleware with an appropriate error message. - */ - -[ - 'json', - 'urlencoded', - 'bodyParser', - 'compress', - 'cookieSession', - 'session', - 'logger', - 'cookieParser', - 'favicon', - 'responseTime', - 'errorHandler', - 'timeout', - 'methodOverride', - 'vhost', - 'csrf', - 'directory', - 'limit', - 'multipart', - 'staticCache', - 'query', -].forEach(function (name) { - Object.defineProperty(exports, name, { - get: function () { - throw new Error('Most middleware (like ' + name + ') is no longer bundled with Express and must be installed separately. Please see https://github.com/senchalabs/connect#middleware.'); - }, - configurable: true - }); -}); diff --git a/test/exports.js b/test/exports.js index d34a7b1c..d2d4e07e 100644 --- a/test/exports.js +++ b/test/exports.js @@ -50,12 +50,4 @@ describe('exports', function(){ .get('/') .expect('bar', done); }) - - it('should throw on old middlewares', function(){ - var error; - try { express.bodyParser; } catch (e) { error = e; } - should(error).have.property('message'); - error.message.should.containEql('middleware'); - error.message.should.containEql('bodyParser'); - }) })